Change resource handling policy to allow feed types to download so they can be handled by web inten…

chrome/browser/download/chrome_download_manager_delegate.cc

Index: chrome/browser/download/chrome_download_manager_delegate.cc
diff --git a/chrome/browser/download/chrome_download_manager_delegate.cc b/chrome/browser/download/chrome_download_manager_delegate.cc
index 65e42702d0cf8fedc400cb577aef16e11f7b7767..b0323ddd25a3921a6fffe22d6d6d09306f2fbe66 100644
--- a/chrome/browser/download/chrome_download_manager_delegate.cc
+++ b/chrome/browser/download/chrome_download_manager_delegate.cc
@@ -260,6 +260,26 @@ bool ChromeDownloadManagerDelegate::ShouldOpenDownload(DownloadItem* item) {
 
 bool ChromeDownloadManagerDelegate::ShouldOpenWithWebIntents(
     const DownloadItem* item) {
+  std::string mime_type = item->GetMimeType();
+  if (mime_type == "application/rss+xml" ||
+      mime_type == "application/atom+xml") {
+    return true;
+  }
+
+#if defined(OS_CHROMEOS)
+  if (mime_type == "application/msword" ||

[darin (slow to review), 2012/04/17 00:03:14]

On ChromeOS, how will I be able to force these MIME types to be downloaded?  For
MIME types rendered by the browser, I can choose File > Save page as.  What is
the equivalent for MIME types that get handled by WebIntents?

[Greg Billock, 2012/04/18 18:01:24]

The web intent is triggered post-download. IOW, the download has already
happened, so if you don't want to open it, you can just cancel the intent at the
picker or close whatever viewer opens automatically.

The download remains downloaded (it doesn't get deleted or anything). I do agree
that File > Save as should mean no intent is triggered. My understanding from
the discussions on the implementation changelist is that we currently don't
propagate that information into the download system. Shall we track that in a
separate bug, and should that gate this change?

On 2012/04/17 00:03:14, darin wrote:

+      mime_type == "application/vnd.ms-powerpoint" ||
+      mime_type == "application/vnd.ms-excel" ||
+      mime_type == "application/vnd.openxmlformats-officedocument."
+                   "wordprocessingml.document" ||
+      mime_type == "application/vnd.openxmlformats-officedocument."
+                   "presentationml.presentation" ||
+      mime_type == "application/vnd.openxmlformats-officedocument."
+                   "spreadsheetml.sheet") {
+    return true;
+  }
+#endif  // defined(OS_CHROMEOS)
+
   return false;
 }