Change resource handling policy to allow feed types to download so they can be handled by web inten…

chrome/browser/download/chrome_download_manager_delegate.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/download/chrome_download_manager_delegate.h"
 
 #include <string>
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
@@ skipping 242 matching lines @@
     OpenWithWebIntent(item);
     item->DelayedDownloadOpened();
     return false;
   }
 
   return true;
 }
 
 bool ChromeDownloadManagerDelegate::ShouldOpenWithWebIntents(
     const DownloadItem* item) {
+  std::string mime_type = item->GetMimeType();
+  if (mime_type == "application/rss+xml" ||
+      mime_type == "application/atom+xml") {
+    return true;
+  }
+
+#if defined(OS_CHROMEOS)
+  if (mime_type == "application/msword" ||

[darin (slow to review), 2012/04/17 00:03:14]

On ChromeOS, how will I be able to force these MIME types to be downloaded?  For
MIME types rendered by the browser, I can choose File > Save page as.  What is
the equivalent for MIME types that get handled by WebIntents?

[Greg Billock, 2012/04/18 18:01:24]

The web intent is triggered post-download. IOW, the download has already
happened, so if you don't want to open it, you can just cancel the intent at the
picker or close whatever viewer opens automatically.

The download remains downloaded (it doesn't get deleted or anything). I do agree
that File > Save as should mean no intent is triggered. My understanding from
the discussions on the implementation changelist is that we currently don't
propagate that information into the download system. Shall we track that in a
separate bug, and should that gate this change?

On 2012/04/17 00:03:14, darin wrote:

+      mime_type == "application/vnd.ms-powerpoint" ||
+      mime_type == "application/vnd.ms-excel" ||
+      mime_type == "application/vnd.openxmlformats-officedocument."
+                   "wordprocessingml.document" ||
+      mime_type == "application/vnd.openxmlformats-officedocument."
+                   "presentationml.presentation" ||
+      mime_type == "application/vnd.openxmlformats-officedocument."
+                   "spreadsheetml.sheet") {
+    return true;
+  }
+#endif  // defined(OS_CHROMEOS)
+
   return false;
 }
 
 void ChromeDownloadManagerDelegate::OpenWithWebIntent(
     const DownloadItem* item) {
   webkit_glue::WebIntentData intent_data(
       ASCIIToUTF16("http://webintents.org/view"),
       ASCIIToUTF16(item->GetMimeType()),
       item->GetFullPath(),
       item->GetReceivedBytes());
@@ skipping 404 matching lines @@
     int32 download_id, int64 db_handle) {
   // It's not immediately obvious, but HistoryBackend::CreateDownload() can
   // call this function with an invalid |db_handle|. For instance, this can
   // happen when the history database is offline. We cannot have multiple
   // DownloadItems with the same invalid db_handle, so we need to assign a
   // unique |db_handle| here.
   if (db_handle == DownloadItem::kUninitializedHandle)
     db_handle = download_history_->GetNextFakeDbHandle();
   download_manager_->OnItemAddedToPersistentStore(download_id, db_handle);
 }