Change resource handling policy to allow feed types to download so they can be handled by web inten…

Change resource handling policy to allow feed types to download so they can be handled by web intents.

BUG=105732
TEST=None


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=133456

[willchan no longer on Chromium, 2012-04-16 23:49:14]

This will cause a minor change in our histograms that record the compressibility
of content. I think that's fine, so LGTM.

That said, the fact that this same list controls whether or not we render
content is broken. I think this is a layering violation and we ought to keep
separate lists.

Let's see if Darin agrees with me or not :) I don't really understand the full
history of mime_util.cc, but I think everything's there just because some other
parts of mime_util are used in net/.

[darin (slow to review), 2012-04-17 00:01:09]

On 2012/04/16 23:49:14, willchan wrote:
> Let's see if Darin agrees with me or not :) I don't really understand the full
> history of mime_util.cc, but I think everything's there just because some
other
> parts of mime_util are used in net/.

Yes, mime_util.{h,cc} never really belonged entirely in the net/ module.  Much
of it belongs at a higher level.  We should probably just factor out the lists
into a registry that can be configured by Chrome at startup.

[darin (slow to review), 2012-04-17 00:03:14]

LGTM

http://codereview.chromium.org/10079012/diff/1/chrome/browser/download/chrome...
File chrome/browser/download/chrome_download_manager_delegate.cc (right):

http://codereview.chromium.org/10079012/diff/1/chrome/browser/download/chrome...
chrome/browser/download/chrome_download_manager_delegate.cc:270: if (mime_type
== "application/msword" ||
On ChromeOS, how will I be able to force these MIME types to be downloaded?  For
MIME types rendered by the browser, I can choose File > Save page as.  What is
the equivalent for MIME types that get handled by WebIntents?

[cbentzel, 2012-04-17 15:43:41]

+asanka

[asanka, 2012-04-17 18:52:23]

Is the intent here to allow a plug-in to override web intents? Or do you want to
always force these MIME types to be downloaded?

[Greg Billock, 2012-04-18 18:01:24]

http://codereview.chromium.org/10079012/diff/1/chrome/browser/download/chrome...
File chrome/browser/download/chrome_download_manager_delegate.cc (right):

http://codereview.chromium.org/10079012/diff/1/chrome/browser/download/chrome...
chrome/browser/download/chrome_download_manager_delegate.cc:270: if (mime_type
== "application/msword" ||
The web intent is triggered post-download. IOW, the download has already
happened, so if you don't want to open it, you can just cancel the intent at the
picker or close whatever viewer opens automatically.

The download remains downloaded (it doesn't get deleted or anything). I do agree
that File > Save as should mean no intent is triggered. My understanding from
the discussions on the implementation changelist is that we currently don't
propagate that information into the download system. Shall we track that in a
separate bug, and should that gate this change?

On 2012/04/17 00:03:14, darin wrote:
> On ChromeOS, how will I be able to force these MIME types to be downloaded? 
For
> MIME types rendered by the browser, I can choose File > Save page as.  What is
> the equivalent for MIME types that get handled by WebIntents?

[commit-bot: I haz the power, 2012-04-23 14:40:29]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/gbillock@chromium.org/10079012/8001

[commit-bot: I haz the power, 2012-04-23 16:07:56]

Change committed as 133456