tools/clang/plugins/tests/overridden_methods.txt - Issue 10076002: Check implementation files for virtual and OVERRIDE

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/clang/plugins/tests/overridden_methods.txt

Issue 10076002: Check implementation files for virtual and OVERRIDE (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Copyright bump Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/clang/plugins/tests/overridden_methods.txt

diff --git a/tools/clang/plugins/tests/overridden_methods.txt b/tools/clang/plugins/tests/overridden_methods.txt

index a405d3102264582031e142761a6cc63f4eab041e..7553ade70e6d79a1129686da4b8ac385e0f23ab6 100644

--- a/tools/clang/plugins/tests/overridden_methods.txt

+++ b/tools/clang/plugins/tests/overridden_methods.txt

@@ -8,4 +8,13 @@ In file included from overridden_methods.cpp:5:

./overridden_methods.h:51:11: warning: [chromium-style] Overriding method must be marked with OVERRIDE.

virtual void SomeNonPureBaseMethod() {}

-3 warnings generated.

+overridden_methods.cpp:24:11: warning: [chromium-style] Overriding method must be marked with OVERRIDE.

+ virtual void SomeMethod();

+ ^

+overridden_methods.cpp:28:11: warning: [chromium-style] Overriding method must be marked with OVERRIDE.

+ virtual void SomeInlineMethod() {}

+ ^

+overridden_methods.cpp:32:11: warning: [chromium-style] Overriding method must be marked with OVERRIDE.

+ virtual void SomeNonPureBaseMethod() {}

+ ^

+6 warnings generated.