tools/clang/plugins/tests/overridden_methods.txt - Issue 10076002: Check implementation files for virtual and OVERRIDE

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: tools/clang/plugins/tests/overridden_methods.txt

Issue 10076002: Check implementation files for virtual and OVERRIDE (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Copyright bump Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 In file included from overridden_methods.cpp:5:	1 In file included from overridden_methods.cpp:5:

2 ./overridden_methods.h:43:11: warning: [chromium-style] Overriding method must b e marked with OVERRIDE.	2 ./overridden_methods.h:43:11: warning: [chromium-style] Overriding method must b e marked with OVERRIDE.

3 virtual void SomeMethod();	3 virtual void SomeMethod();

4 ^	4 ^

5 ./overridden_methods.h:47:11: warning: [chromium-style] Overriding method must b e marked with OVERRIDE.	5 ./overridden_methods.h:47:11: warning: [chromium-style] Overriding method must b e marked with OVERRIDE.

6 virtual void SomeInlineMethod() {}	6 virtual void SomeInlineMethod() {}

7 ^	7 ^

8 ./overridden_methods.h:51:11: warning: [chromium-style] Overriding method must b e marked with OVERRIDE.	8 ./overridden_methods.h:51:11: warning: [chromium-style] Overriding method must b e marked with OVERRIDE.

9 virtual void SomeNonPureBaseMethod() {}	9 virtual void SomeNonPureBaseMethod() {}

10 ^	10 ^

11 3 warnings generated.	11 overridden_methods.cpp:24:11: warning: [chromium-style] Overriding method must b e marked with OVERRIDE.

	12 virtual void SomeMethod();

	13 ^

	14 overridden_methods.cpp:28:11: warning: [chromium-style] Overriding method must b e marked with OVERRIDE.

	15 virtual void SomeInlineMethod() {}

	16 ^

	17 overridden_methods.cpp:32:11: warning: [chromium-style] Overriding method must b e marked with OVERRIDE.

	18 virtual void SomeNonPureBaseMethod() {}

	19 ^

	20 6 warnings generated.

OLD	NEW