Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(620)

Unified Diff: net/test/local_test_server_posix.cc

Issue 10073033: Run safebrowsing_service_test through the net testserver code. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/test/local_test_server_posix.cc
diff --git a/net/test/local_test_server_posix.cc b/net/test/local_test_server_posix.cc
index 3756b69f4395974dd68a4246a2d105d519ddc501..8fcd72a8e68bbce69ed71c34fd5053cf5f65f96e 100644
--- a/net/test/local_test_server_posix.cc
+++ b/net/test/local_test_server_posix.cc
@@ -101,6 +101,10 @@ bool LocalTestServer::LaunchPython(const FilePath& testserver_path) {
getenv(kPythonPathEnv);
CommandLine python_command(FilePath(FILE_PATH_LITERAL("python")));
+ // Make python stdout and stderr unbuffered, to prevent incomplete stderr on
Paweł Hajdan Jr. 2012/04/17 06:38:05 I'm not sure this is the right fix. How about just
mattm 2012/04/18 00:20:00 I think this still wouldn't solve the issue of inc
+ // win bots, and also fix mixed up ordering of stdout and stderr.
+ python_command.AppendSwitch("-u");
+
python_command.AppendArgPath(testserver_path);
if (!AddCommandLineArguments(&python_command))
return false;

Powered by Google App Engine
This is Rietveld 408576698