Run safebrowsing_service_test through the net testserver code.

net/test/local_test_server_posix.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/test/local_test_server.h"
 
 #include <poll.h>
 
 #include <vector>
 
@@ skipping 83 matching lines @@
 
 namespace net {
 
 bool LocalTestServer::LaunchPython(const FilePath& testserver_path) {
   // Log is useful in the event you want to run a nearby script (e.g. a test) in
   // the same environment as the TestServer.
   VLOG(1) << "LaunchPython called with PYTHONPATH = " <<
           getenv(kPythonPathEnv);
   CommandLine python_command(FilePath(FILE_PATH_LITERAL("python")));
 
+  // Make python stdout and stderr unbuffered, to prevent incomplete stderr on

[Paweł Hajdan Jr., 2012/04/17 06:38:05]

I'm not sure this is the right fix. How about just making stderr and stdout go
to the same fd?

Also, the comment mentions Windows, but this file is POSIX-specific.

[mattm, 2012/04/18 00:20:00]

I think this still wouldn't solve the issue of incomplete output.  (I just took
another look and both stdout and stderr are truncated, but the stdout is just
hard to tell since it's at the end of a super long line.)
fixed.

+  // win bots, and also fix mixed up ordering of stdout and stderr.
+  python_command.AppendSwitch("-u");
+
   python_command.AppendArgPath(testserver_path);
   if (!AddCommandLineArguments(&python_command))
     return false;
 
   int pipefd[2];
   if (pipe(pipefd) != 0) {
     PLOG(ERROR) << "Could not create pipe.";
     return false;
   }
 
@@ skipping 48 matching lines @@
 
   if (!ParseServerData(server_data)) {
     LOG(ERROR) << "Could not parse server_data: " << server_data;
     return false;
   }
 
   return true;
 }
 
 }  // namespace net