Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Unified Diff: net/android/java/java.gyp

Issue 10073024: Add NetworkChangeNotifier for Android. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/android/java/java.gyp
diff --git a/net/android/java/java.gyp b/net/android/java/java.gyp
new file mode 100644
index 0000000000000000000000000000000000000000..d9b48bda2797d82d5450b86b7770282ae8e261f1
--- /dev/null
+++ b/net/android/java/java.gyp
@@ -0,0 +1,33 @@
+# Copyright (c) 2012 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+{
+ 'targets': [
+ {
+ 'target_name': 'net_java',
+ 'message': 'building net java sources',
+ 'type': 'none',
+ 'actions': [
+ {
+ 'action_name': 'net_java',
+ 'inputs': [
+ '<(DEPTH)/net/android/java/net.xml',
Ryan Sleevi 2012/04/13 22:37:58 In Chromium code, we really, really try to minimiz
Yaron 2012/04/17 16:18:03 It's not. I didn't realize it was frowned upon.
+ '<!@(find <(DEPTH)/net/android/java -name "*.java")'
Ryan Sleevi 2012/04/13 22:37:58 This is really not ideal. The request for this has
Yaron 2012/04/17 16:18:03 This was discussed in the spin-off bug
+ ],
+ 'dependencies': [
+ '<(DEPTH)/base/android/java/java.gyp:base_java',
+ ],
+ 'outputs': [
+ '<(DEPTH)/net/android/java/dist/lib/chromium_net.jar',
John Grabowski 2012/04/13 22:37:30 let's put output in a standard location outside th
Ryan Sleevi 2012/04/13 22:37:58 Dropping files into the source tree = please avoid
Yaron 2012/04/17 16:18:03 Yep, I agree but was again following base for cons
Yaron 2012/04/17 16:18:03 Done.
+ ],
+ 'action': [
+ 'ant',
+ '-buildfile',
John Grabowski 2012/04/13 22:37:30 see more stuff here see http://chromiumcodereview.
Yaron 2012/04/17 16:18:03 Done.
+ '<(DEPTH)/net/android/java/net.xml',
Ryan Sleevi 2012/04/13 22:37:58 Rather than repeat this (shared with src/base/andr
Yaron 2012/04/17 16:18:03 Done.
+ ]
+ },
+ ],
+ },
+ ],
+}

Powered by Google App Engine
This is Rietveld 408576698