net/android/java/java.gyp - Issue 10073024: Add NetworkChangeNotifier for Android.

Side by Side Diff: net/android/java/java.gyp

Issue 10073024: Add NetworkChangeNotifier for Android. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
(Empty)
	1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.

	2 # Use of this source code is governed by a BSD-style license that can be

	3 # found in the LICENSE file.

	4

	5 {

	6 'targets': [

	7 {

	8 'target_name': 'net_java',

	9 'message': 'building net java sources',

	10 'type': 'none',

	11 'actions': [

	12 {

	13 'action_name': 'net_java',

	14 'inputs': [

	15 '<(DEPTH)/net/android/java/net.xml',
	Ryan Sleevi 2012/04/13 22:37:58 In Chromium code, we really, really try to minimiz In Chromium code, we really, really try to minimize the use of '<(DEPTH)'. The exception being the WebKit code, as there's Chromium-In-WebKit (over in the WK tree) as much as there is WebKit-in-Chromium (as it is in the Chromium tree). Can you explain why this is necessary? Yaron 2012/04/17 16:18:03 It's not. I didn't realize it was frowned upon. Show quoted text On 2012/04/13 22:37:58, Ryan Sleevi wrote: > In Chromium code, we really, really try to minimize the use of '<(DEPTH)'. The > exception being the WebKit code, as there's Chromium-In-WebKit (over in the WK > tree) as much as there is WebKit-in-Chromium (as it is in the Chromium tree). > > Can you explain why this is necessary? It's not. I didn't realize it was frowned upon.
	16 '<!@(find <(DEPTH)/net/android/java -name "*.java")'
	Ryan Sleevi 2012/04/13 22:37:58 This is really not ideal. The request for this has This is really not ideal. The request for this has come up several times on gyp-developer, and this has consistently been dismissed as not consistent with the syntax GYP tries to promote (even though yes, it does work). I'd really like to push back on this before it becomes wide-spread, as I raised it when base/android/java/java.gyp landed Note also that base/android/java/java.gyp makes some implicit assumptions about where subcommands are run that are not guaranteed to hold. I see you've avoided this by using <(DEPTH) (which is good), but base/android/... will need to be fixed at some point. Yaron 2012/04/17 16:18:03 This was discussed in the spin-off bug Show quoted text On 2012/04/13 22:37:58, Ryan Sleevi wrote: > This is really not ideal. The request for this has come up several times on > gyp-developer, and this has consistently been dismissed as not consistent with > the syntax GYP tries to promote (even though yes, it does work). > > I'd really like to push back on this before it becomes wide-spread, as I raised > it when base/android/java/java.gyp landed > > Note also that base/android/java/java.gyp makes some implicit assumptions about > where subcommands are run that are not guaranteed to hold. I see you've avoided > this by using <(DEPTH) (which is good), but base/android/... will need to be > fixed at some point. This was discussed in the spin-off bug
	17 ],

	18 'dependencies': [

	19 '<(DEPTH)/base/android/java/java.gyp:base_java',

	20 ],

	21 'outputs': [

	22 '<(DEPTH)/net/android/java/dist/lib/chromium_net.jar',
	John Grabowski 2012/04/13 22:37:30 let's put output in a standard location outside th let's put output in a standard location outside the source tree E.g. see <property name="out.dir" location="${PRODUCT_DIR}"/> in http://chromiumcodereview.appspot.com/10051021/diff/8004/base/android/java/ba... (and the gyp change that defines it) Ryan Sleevi 2012/04/13 22:37:58 Dropping files into the source tree = please avoid Dropping files into the source tree = please avoid at all costs. See comments on net.xml Yaron 2012/04/17 16:18:03 Yep, I agree but was again following base for cons Show quoted text On 2012/04/13 22:37:58, Ryan Sleevi wrote: > Dropping files into the source tree = please avoid at all costs. See comments on > net.xml Yep, I agree but was again following base for consistency and figured they'd all be fixed together. John's fixing this in http://codereview.chromium.org/10051021 and I figured he'd land first and I'd update accordingly but I'll make the changes now. Yaron 2012/04/17 16:18:03 Done. Show quoted text On 2012/04/13 22:37:30, John Grabowski wrote: > let's put output in a standard location outside the source tree > E.g. see > <property name="out.dir" location="${PRODUCT_DIR}"/> > in > http://chromiumcodereview.appspot.com/10051021/diff/8004/base/android/java/ba... > (and the gyp change that defines it) Done.
	23 ],

	24 'action': [

	25 'ant',

	26 '-buildfile',
	John Grabowski 2012/04/13 22:37:30 see more stuff here see http://chromiumcodereview. see more stuff here see http://chromiumcodereview.appspot.com/10051021/diff/8004/base/android/java/ja... Yaron 2012/04/17 16:18:03 Done. Show quoted text On 2012/04/13 22:37:30, John Grabowski wrote: > see more stuff here > see > http://chromiumcodereview.appspot.com/10051021/diff/8004/base/android/java/ja... Done.
	27 '<(DEPTH)/net/android/java/net.xml',
	Ryan Sleevi 2012/04/13 22:37:58 Rather than repeat this (shared with src/base/andr Rather than repeat this (shared with src/base/android/java/java.gyp), consider using an 'java.gypi' target combined with 'variables' to set the appropriate outputs as needed. 'java.gypi' can then defer to 'ant'. An example of how to do this can be seen with 'protoc.gypi' Yaron 2012/04/17 16:18:03 Done. Show quoted text On 2012/04/13 22:37:58, Ryan Sleevi wrote: > Rather than repeat this (shared with src/base/android/java/java.gyp), consider > using an 'java.gypi' target combined with 'variables' to set the appropriate > outputs as needed. > > 'java.gypi' can then defer to 'ant'. > > An example of how to do this can be seen with 'protoc.gypi' Done.
	28 ]

	29 },

	30 ],

	31 },

	32 ],

	33 }

OLD	NEW

« no previous file with comments | « base/android/jni_generator/jni_generator.py ('k') | net/android/java/net.xml » ('j') | net/android/java/net.xml » ('J')