Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Issue 10073023: TabContents -> WebContentsImpl, part 14. (Closed)

Created:
8 years, 8 months ago by Avi (use Gerrit)
Modified:
8 years, 8 months ago
Reviewers:
jam
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, creis+watch_chromium.org, ajwong+watch_chromium.org
Visibility:
Public.

Description

TabContents -> WebContentsImpl, part 14. Updated comments. BUG=105875 TEST=no change Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=132406

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -79 lines) Patch
M content/browser/cross_site_request_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/resource_dispatcher_host_uitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/site_instance_impl_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/speech/speech_recognition_manager_impl.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M content/browser/ssl/ssl_cert_error_handler.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M content/browser/ssl/ssl_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/ssl/ssl_policy.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/webui/web_ui_impl.h View 1 chunk +3 lines, -3 lines 0 comments Download
M content/common/npobject_util.h View 1 chunk +1 line, -1 line 0 comments Download
M content/common/view_messages.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/public/browser/devtools_client_host.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/public/browser/navigation_entry.h View 1 chunk +1 line, -1 line 0 comments Download
M content/public/browser/notification_types.h View 3 chunks +5 lines, -5 lines 0 comments Download
M content/public/browser/page_navigator.h View 1 chunk +1 line, -1 line 0 comments Download
M content/public/browser/render_view_host.h View 1 chunk +1 line, -1 line 0 comments Download
M content/public/browser/render_view_host_delegate.h View 3 chunks +5 lines, -5 lines 0 comments Download
M content/public/browser/render_widget_host.h View 2 chunks +14 lines, -22 lines 0 comments Download
M content/public/browser/site_instance.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/public/browser/web_contents.h View 4 chunks +9 lines, -10 lines 0 comments Download
M content/public/common/page_type.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/dom_automation_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_thread_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_view_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/test/test_renderer_host.h View 1 chunk +1 line, -1 line 0 comments Download
M content/test/test_renderer_host.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Avi (use Gerrit)
Note that I deleted some commentary that was flat-out wrong (NavControllers owning TabContents?!) or irrelevant ...
8 years, 8 months ago (2012-04-13 22:03:53 UTC) #1
Avi (use Gerrit)
On 2012/04/13 22:03:53, Avi wrote: > NavControllers owning TabContents?! That changed, BTW, with r14053, nearly ...
8 years, 8 months ago (2012-04-14 01:37:48 UTC) #2
jam
lgtm btw would you mind updating the wiki as well (http://dev.chromium.org/developers/design-documents/displaying-a-web-page-in-chrome comes to mind)
8 years, 8 months ago (2012-04-15 22:12:29 UTC) #3
Avi (use Gerrit)
On 2012/04/15 22:12:29, John Abd-El-Malek wrote: > btw would you mind updating the wiki as ...
8 years, 8 months ago (2012-04-16 00:10:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/10073023/1
8 years, 8 months ago (2012-04-16 14:01:39 UTC) #5
commit-bot: I haz the power
Change committed as 132406
8 years, 8 months ago (2012-04-16 15:58:15 UTC) #6
jam
8 years, 8 months ago (2012-04-17 03:16:15 UTC) #7
On 2012/04/16 00:10:47, Avi wrote:
> On 2012/04/15 22:12:29, John Abd-El-Malek wrote:
> > btw would you mind updating the wiki as well
> 
> Can I expense the copy of Adobe Illustrator? :)

that's between you and your manager :) this is why i prefer drawings in google
docs, because anyone can edit those.

Powered by Google App Engine
This is Rietveld 408576698