Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Unified Diff: content/browser/speech/speech_recognition_manager_impl.cc

Issue 10073023: TabContents -> WebContentsImpl, part 14. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/site_instance_impl_unittest.cc ('k') | content/browser/ssl/ssl_cert_error_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/speech/speech_recognition_manager_impl.cc
diff --git a/content/browser/speech/speech_recognition_manager_impl.cc b/content/browser/speech/speech_recognition_manager_impl.cc
index 7600b508093f9fee129e2d25f94f9f52e1959c92..40218715a8b4c63cee6af5d7f50a62f524f05106 100644
--- a/content/browser/speech/speech_recognition_manager_impl.cc
+++ b/content/browser/speech/speech_recognition_manager_impl.cc
@@ -152,12 +152,12 @@ void SpeechRecognitionManagerImpl::CheckRenderViewTypeAndStartRecognition(
if (!render_view_host || !render_view_host->GetDelegate())
return;
- // For host delegates other than TabContents we can't reliably show a popup,
- // including the speech input bubble. In these cases for privacy reasons we
- // don't want to start recording if the user can't be properly notified.
- // An example of this is trying to show the speech input bubble within an
- // extension popup: http://crbug.com/92083. In these situations the speech
- // input extension API should be used instead.
+ // For host delegates other than VIEW_TYPE_TAB_CONTENTS we can't reliably show
+ // a popup, including the speech input bubble. In these cases for privacy
+ // reasons we don't want to start recording if the user can't be properly
+ // notified. An example of this is trying to show the speech input bubble
+ // within an extension popup: http://crbug.com/92083. In these situations the
+ // speech input extension API should be used instead.
if (render_view_host->GetDelegate()->GetRenderViewType() ==
content::VIEW_TYPE_TAB_CONTENTS) {
BrowserThread::PostTask(
« no previous file with comments | « content/browser/site_instance_impl_unittest.cc ('k') | content/browser/ssl/ssl_cert_error_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698