Remove Active Downloads UI.

Remove Active Downloads UI.

This is no longer in use since ChromeOS is now always building USE_AURA.

BUG=none
TEST=compiles


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=133540

[achuithb, 2012-04-16 14:27:05]

http://codereview.chromium.org/10073017/diff/1/chrome/browser/download/downlo...
File chrome/browser/download/download_browsertest.cc (right):

http://codereview.chromium.org/10073017/diff/1/chrome/browser/download/downlo...
chrome/browser/download/download_browsertest.cc:586: void
CheckDownloadShelfVisibility(Browser* browser,
Not sure if this function and the enum is worth it. Might be more readable to
directly use EXPECT_EQ(true, browser->window()->IsDownloadShelfVisible());

http://codereview.chromium.org/10073017/diff/1/chrome/browser/download/save_p...
File chrome/browser/download/save_page_browsertest.cc (right):

http://codereview.chromium.org/10073017/diff/1/chrome/browser/download/save_p...
chrome/browser/download/save_page_browsertest.cc:100: void
CheckDownloadShelfIsVisible() const {
Not sure if the indirection is worthwhile. Might be better to replace all
instances of this function with the function body.

[asanka, 2012-04-17 20:02:25]

http://codereview.chromium.org/10073017/diff/1/chrome/browser/download/downlo...
File chrome/browser/download/download_browsertest.cc (right):

http://codereview.chromium.org/10073017/diff/1/chrome/browser/download/downlo...
chrome/browser/download/download_browsertest.cc:586: void
CheckDownloadShelfVisibility(Browser* browser,
On 2012/04/16 14:27:05, achuith.bhandarkar wrote:
> Not sure if this function and the enum is worth it. Might be more readable to
> directly use EXPECT_EQ(true, browser->window()->IsDownloadShelfVisible());

Done.

http://codereview.chromium.org/10073017/diff/1/chrome/browser/download/save_p...
File chrome/browser/download/save_page_browsertest.cc (right):

http://codereview.chromium.org/10073017/diff/1/chrome/browser/download/save_p...
chrome/browser/download/save_page_browsertest.cc:100: void
CheckDownloadShelfIsVisible() const {
On 2012/04/16 14:27:05, achuith.bhandarkar wrote:
> Not sure if the indirection is worthwhile. Might be better to replace all
> instances of this function with the function body.

Done.

[achuithb, 2012-04-19 19:46:21]

LGTM.

[achuithb, 2012-04-19 19:46:53]

On 2012/04/19 19:46:21, achuith.bhandarkar wrote:
> LGTM.

Please run linux_chromeos and linux_chromeos_clang trybots please.

[asanka, 2012-04-23 19:13:43]

On 2012/04/19 19:46:53, achuith.bhandarkar wrote:
> On 2012/04/19 19:46:21, achuith.bhandarkar wrote:
> > LGTM.
> 
> Please run linux_chromeos and linux_chromeos_clang trybots please.

Done. Thanks!

+jhawkins for chrome/browser/resources/OWNERS

+sky FYI.

[James Hawkins, 2012-04-23 19:38:04]

resources LGTM

[sky, 2012-04-23 20:52:45]

Nice!

[commit-bot: I haz the power, 2012-04-23 20:55:06]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/asanka@chromium.org/10073017/13001

[commit-bot: I haz the power, 2012-04-23 22:34:02]

Change committed as 133540