Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Unified Diff: chrome/browser/download/save_page_browsertest.cc

Issue 10073017: Remove Active Downloads UI. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebased Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/download/save_page_browsertest.cc
diff --git a/chrome/browser/download/save_page_browsertest.cc b/chrome/browser/download/save_page_browsertest.cc
index 9a0762588663fd9bc1fac568784dfac928dd640d..3b0cfcaf7390baa3b23863228d1d701bfa6bd2f6 100644
--- a/chrome/browser/download/save_page_browsertest.cc
+++ b/chrome/browser/download/save_page_browsertest.cc
@@ -97,10 +97,6 @@ class SavePageBrowserTest : public InProcessBrowserTest {
GetOriginalUrl();
}
- void CheckDownloadUI(const FilePath& download_path) const {
- EXPECT_TRUE(browser()->window()->IsDownloadShelfVisible());
- }
-
DownloadManager* GetDownloadManager() const {
DownloadManager* download_manager =
DownloadServiceFactory::GetForProfile(
@@ -185,7 +181,7 @@ IN_PROC_BROWSER_TEST_F(SavePageBrowserTest, SaveHTMLOnly) {
EXPECT_EQ(url, WaitForSavePackageToFinish());
- CheckDownloadUI(full_file_name);
+ EXPECT_TRUE(browser()->window()->IsDownloadShelfVisible());
CheckDownloadHistory(url, full_file_name, 1); // a.htm is 1 file.
EXPECT_TRUE(file_util::PathExists(full_file_name));
@@ -210,7 +206,7 @@ IN_PROC_BROWSER_TEST_F(SavePageBrowserTest, SaveViewSourceHTMLOnly) {
EXPECT_EQ(actual_page_url, WaitForSavePackageToFinish());
- CheckDownloadUI(full_file_name);
+ EXPECT_TRUE(browser()->window()->IsDownloadShelfVisible());
CheckDownloadHistory(actual_page_url, full_file_name, 1); // a.htm is 1 file.
EXPECT_TRUE(file_util::PathExists(full_file_name));
@@ -230,7 +226,7 @@ IN_PROC_BROWSER_TEST_F(SavePageBrowserTest, SaveCompleteHTML) {
EXPECT_EQ(url, WaitForSavePackageToFinish());
- CheckDownloadUI(full_file_name);
+ EXPECT_TRUE(browser()->window()->IsDownloadShelfVisible());
CheckDownloadHistory(url, full_file_name, 3); // b.htm is 3 files.
EXPECT_TRUE(file_util::PathExists(full_file_name));
@@ -264,7 +260,7 @@ IN_PROC_BROWSER_TEST_F(SavePageBrowserTest, FileNameFromPageTitle) {
EXPECT_EQ(url, WaitForSavePackageToFinish());
- CheckDownloadUI(full_file_name);
+ EXPECT_TRUE(browser()->window()->IsDownloadShelfVisible());
CheckDownloadHistory(url, full_file_name, 3); // b.htm is 3 files.
EXPECT_TRUE(file_util::PathExists(full_file_name));
@@ -290,7 +286,7 @@ IN_PROC_BROWSER_TEST_F(SavePageBrowserTest, RemoveFromList) {
EXPECT_EQ(url, WaitForSavePackageToFinish());
- CheckDownloadUI(full_file_name);
+ EXPECT_TRUE(browser()->window()->IsDownloadShelfVisible());
CheckDownloadHistory(url, full_file_name, 1); // a.htm is 1 file.
EXPECT_EQ(GetDownloadManager()->RemoveAllDownloads(), 1);
« no previous file with comments | « chrome/browser/download/download_browsertest.cc ('k') | chrome/browser/resources/chromeos/active_downloads.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698