Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 10073002: TabContents -> WebContentsImpl, part 11. (Closed)

Created:
8 years, 8 months ago by Avi (use Gerrit)
Modified:
8 years, 8 months ago
Reviewers:
jam
CC:
chromium-reviews, yusukes+watch_chromium.org, jam, penghuang+watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, James Su
Visibility:
Public.

Description

TabContents -> WebContentsImpl, part 11. "Detab" content/browser/renderer_host. BUG=105875 TEST=no change Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=132194

Patch Set 1 #

Patch Set 2 : *web*contents #

Patch Set 3 : missed header files #

Patch Set 4 : missed a few #

Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -89 lines) Patch
M content/browser/renderer_host/cross_site_resource_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/cross_site_resource_handler.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/renderer_host/java/java_bridge_dispatcher_host_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_message_filter.h View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_message_filter.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_process_host_impl.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 3 chunks +5 lines, -5 lines 0 comments Download
M content/browser/renderer_host/render_view_host_impl.h View 3 chunks +15 lines, -14 lines 0 comments Download
M content/browser/renderer_host/render_view_host_impl.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M content/browser/renderer_host/render_view_host_unittest.cc View 1 3 chunks +4 lines, -3 lines 0 comments Download
M content/browser/renderer_host/render_widget_helper.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_gtk.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_gtk.cc View 1 2 chunks +8 lines, -8 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac.mm View 1 2 3 3 chunks +16 lines, -14 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_win.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_win.cc View 1 2 3 6 chunks +18 lines, -18 lines 0 comments Download
M content/browser/renderer_host/resource_dispatcher_host_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/resource_request_info_impl.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/renderer_host/test_render_view_host.h View 2 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Avi (use Gerrit)
8 years, 8 months ago (2012-04-12 18:27:29 UTC) #1
jam
in comments and variable name where you switched "tab" to "contents", i think it would ...
8 years, 8 months ago (2012-04-12 18:46:58 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/10073002/3001
8 years, 8 months ago (2012-04-12 19:14:26 UTC) #3
commit-bot: I haz the power
Try job failure for 10073002-3001 (retry) on linux_rel for step "compile" (clobber build). It's a ...
8 years, 8 months ago (2012-04-12 19:47:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/10073002/6003
8 years, 8 months ago (2012-04-12 22:16:45 UTC) #5
commit-bot: I haz the power
Try job failure for 10073002-6003 (retry) on mac_rel for step "compile" (clobber build). It's a ...
8 years, 8 months ago (2012-04-12 22:55:13 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/10073002/14001
8 years, 8 months ago (2012-04-13 14:26:09 UTC) #7
commit-bot: I haz the power
8 years, 8 months ago (2012-04-13 15:52:42 UTC) #8
Change committed as 132194

Powered by Google App Engine
This is Rietveld 408576698