Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Unified Diff: content/browser/renderer_host/render_view_host_unittest.cc

Issue 10073002: TabContents -> WebContentsImpl, part 11. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: missed a few Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_view_host_unittest.cc
diff --git a/content/browser/renderer_host/render_view_host_unittest.cc b/content/browser/renderer_host/render_view_host_unittest.cc
index dda613104b18ac5f9f38292b08973a0b336f0367..7dafab07f014ac438072cc6f5b3e1b40da5f30af 100644
--- a/content/browser/renderer_host/render_view_host_unittest.cc
+++ b/content/browser/renderer_host/render_view_host_unittest.cc
@@ -36,7 +36,8 @@ TEST_F(RenderViewHostTest, CreateFullscreenWidget) {
// Makes sure that RenderViewHost::is_waiting_for_unload_ack_ is false when
// reloading a page. If is_waiting_for_unload_ack_ is not false when reloading
-// the tab may get closed out even though the user pressed the reload button.
+// the contents may get closed out even though the user pressed the reload
+// button.
TEST_F(RenderViewHostTest, ResetUnloadOnReload) {
const GURL url1("http://foo1");
const GURL url2("http://foo2");
@@ -51,7 +52,7 @@ TEST_F(RenderViewHostTest, ResetUnloadOnReload) {
// . click stop before the page has been commited.
// . click reload.
// . is_waiting_for_unload_ack_ is still true, and the if the hang monitor
- // fires the tab gets closed.
+ // fires the contents gets closed.
NavigateAndCommit(url1);
controller().LoadURL(
@@ -68,7 +69,7 @@ TEST_F(RenderViewHostTest, ResetUnloadOnReload) {
// Ensure we do not grant bindings to a process shared with unprivileged views.
TEST_F(RenderViewHostTest, DontGrantBindingsToSharedProcess) {
// Create another view in the same process.
- scoped_ptr<TestWebContents> new_tab(
+ scoped_ptr<TestWebContents> new_web_contents(
new TestWebContents(browser_context(), rvh()->GetSiteInstance()));
rvh()->AllowBindings(content::BINDINGS_POLICY_WEB_UI);
« no previous file with comments | « content/browser/renderer_host/render_view_host_impl.cc ('k') | content/browser/renderer_host/render_widget_helper.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698