Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(551)

Unified Diff: content/common/gpu/client/gpu_channel_host.h

Issue 10071038: RefCounted types should not have public destructors, content/browser part 2 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Copyright bump Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/common/db_message_filter.h ('k') | content/common/gpu/client/gpu_channel_host.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/common/gpu/client/gpu_channel_host.h
diff --git a/content/common/gpu/client/gpu_channel_host.h b/content/common/gpu/client/gpu_channel_host.h
index b82efe92764814d62fcb2606b088ce550a00a200..179a78056407348ab47278f5802df5a95b715399 100644
--- a/content/common/gpu/client/gpu_channel_host.h
+++ b/content/common/gpu/client/gpu_channel_host.h
@@ -86,7 +86,6 @@ class GpuChannelHost : public IPC::Message::Sender,
GpuChannelHost(GpuChannelHostFactory* factory,
int gpu_host_id,
int client_id);
- virtual ~GpuChannelHost();
// Connect to GPU process channel.
void Connect(const IPC::ChannelHandle& channel_handle);
@@ -157,12 +156,14 @@ class GpuChannelHost : public IPC::Message::Sender,
int client_id() const { return client_id_; }
private:
+ friend class base::RefCountedThreadSafe<GpuChannelHost>;
+ virtual ~GpuChannelHost();
+
// A filter used internally to route incoming messages from the IO thread
// to the correct message loop.
class MessageFilter : public IPC::ChannelProxy::MessageFilter {
public:
explicit MessageFilter(GpuChannelHost* parent);
- virtual ~MessageFilter();
void AddRoute(int route_id,
base::WeakPtr<IPC::Channel::Listener> listener,
@@ -174,6 +175,8 @@ class GpuChannelHost : public IPC::Message::Sender,
virtual void OnChannelError() OVERRIDE;
private:
+ virtual ~MessageFilter();
+
GpuChannelHost* parent_;
typedef base::hash_map<int, GpuListenerInfo> ListenerMap;
« no previous file with comments | « content/common/db_message_filter.h ('k') | content/common/gpu/client/gpu_channel_host.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698