Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(616)

Unified Diff: content/gpu/gpu_watchdog_thread.h

Issue 10071038: RefCounted types should not have public destructors, content/browser part 2 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/gpu/gpu_watchdog_thread.h
diff --git a/content/gpu/gpu_watchdog_thread.h b/content/gpu/gpu_watchdog_thread.h
index 8f3ee90442eb6127f4853f14337650502da70717..e081a856ff7f05d79834964e4b7476ad4ae912dd 100644
--- a/content/gpu/gpu_watchdog_thread.h
+++ b/content/gpu/gpu_watchdog_thread.h
@@ -20,7 +20,6 @@ class GpuWatchdogThread : public base::Thread,
public base::RefCountedThreadSafe<GpuWatchdogThread> {
public:
explicit GpuWatchdogThread(int timeout);
- virtual ~GpuWatchdogThread();
// Accessible on watched thread but only modified by watchdog thread.
bool armed() const { return armed_; }
@@ -34,6 +33,7 @@ class GpuWatchdogThread : public base::Thread,
virtual void CleanUp() OVERRIDE;
private:
+ friend class base::RefCountedThreadSafe<GpuWatchdogThread>;
// An object of this type intercepts the reception and completion of all tasks
// on the watched thread and checks whether the watchdog is armed.
@@ -50,6 +50,8 @@ class GpuWatchdogThread : public base::Thread,
GpuWatchdogThread* watchdog_;
};
+ virtual ~GpuWatchdogThread();
+
void OnAcknowledge();
void OnCheck();
void DeliberatelyTerminateToRecoverFromHang();

Powered by Google App Engine
This is Rietveld 408576698