Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(315)

Unified Diff: content/renderer/media/video_capture_impl_manager.h

Issue 10071038: RefCounted types should not have public destructors, content/browser part 2 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/media/video_capture_impl_manager.h
diff --git a/content/renderer/media/video_capture_impl_manager.h b/content/renderer/media/video_capture_impl_manager.h
index 8427957fbc43527208464cf120c82f7e75d10aee..ca0d7cbc511926872888f6d176df9d5e1bd30d46 100644
--- a/content/renderer/media/video_capture_impl_manager.h
+++ b/content/renderer/media/video_capture_impl_manager.h
@@ -26,7 +26,6 @@ class CONTENT_EXPORT VideoCaptureImplManager
: public base::RefCountedThreadSafe<VideoCaptureImplManager> {
public:
VideoCaptureImplManager();
- virtual ~VideoCaptureImplManager();
// Called by video capture client |handler| to add device referenced
// by |id| to VideoCaptureImplManager's list of opened device list.
@@ -46,6 +45,9 @@ class CONTENT_EXPORT VideoCaptureImplManager
}
private:
+ friend class base::RefCountedThreadSafe<VideoCaptureImplManager>;
+ friend class MockVideoCaptureImplManager;
scherkus (not reviewing) 2012/04/27 20:59:48 is this needed because the dtor isn't protected?
+
struct Device {
Device(VideoCaptureImpl* device,
media::VideoCapture::EventHandler* handler);
@@ -55,6 +57,8 @@ class CONTENT_EXPORT VideoCaptureImplManager
std::list<media::VideoCapture::EventHandler*> clients;
};
+ virtual ~VideoCaptureImplManager();
+
void FreeDevice(VideoCaptureImpl* vc);
typedef std::map<media::VideoCaptureSessionId, Device*> Devices;

Powered by Google App Engine
This is Rietveld 408576698