content/renderer/media/video_capture_message_filter.h - Issue 10071038: RefCounted types should not have public destructors, content/browser part 2

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/video_capture_message_filter.h

Issue 10071038: RefCounted types should not have public destructors, content/browser part 2 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/renderer/media/video_capture_impl_manager.h ('K') | « content/renderer/media/video_capture_impl_unittest.cc ('k') | content/renderer/p2p/p2p_transport_impl_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/media/video_capture_message_filter.h

diff --git a/content/renderer/media/video_capture_message_filter.h b/content/renderer/media/video_capture_message_filter.h

index 9edf74229cf83cd7011b9ca0a65506dbe9b9afe2..7d964ad1ae7e3e363be3cbc1c8f888c5cd2fb2ec 100644

--- a/content/renderer/media/video_capture_message_filter.h

+++ b/content/renderer/media/video_capture_message_filter.h

@@ -49,7 +49,6 @@ class CONTENT_EXPORT VideoCaptureMessageFilter

};

VideoCaptureMessageFilter();

- virtual ~VideoCaptureMessageFilter();

// Add a delegate to the map.

void AddDelegate(Delegate* delegate);

@@ -61,11 +60,14 @@ class CONTENT_EXPORT VideoCaptureMessageFilter

virtual bool Send(IPC::Message* message);

private:

+ friend class MockVideoCaptureMessageFilter;

scherkus (not reviewing) 2012/04/27 20:59:48 nit: is this needed because dtor isn't protected?

FRIEND_TEST_ALL_PREFIXES(VideoCaptureMessageFilterTest, Basic);

FRIEND_TEST_ALL_PREFIXES(VideoCaptureMessageFilterTest, Delegates);

typedef std::map<int32, Delegate*> Delegates;

+ virtual ~VideoCaptureMessageFilter();

// IPC::ChannelProxy::MessageFilter override. Called on IO thread.

virtual bool OnMessageReceived(const IPC::Message& message) OVERRIDE;

virtual void OnFilterAdded(IPC::Channel* channel) OVERRIDE;