chrome/browser/rlz/rlz_extension_apitest.cc - Issue 10071036: RefCounted types should not have public destructors, chrome/browser/ part 6

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/rlz/rlz_extension_apitest.cc

Issue 10071036: RefCounted types should not have public destructors, chrome/browser/ part 6 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Implementation fixes Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/rlz/rlz_extension_api.h ('k') | chrome/browser/search_engines/search_provider_install_state_message_filter.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/rlz/rlz_extension_apitest.cc

diff --git a/chrome/browser/rlz/rlz_extension_apitest.cc b/chrome/browser/rlz/rlz_extension_apitest.cc

index 7a1810b717d7e58b59effba3b9925e5ad8b6ef76..f60d413e8c68e61892ab4444ad28e639ef45c67e 100644

--- a/chrome/browser/rlz/rlz_extension_apitest.cc

+++ b/chrome/browser/rlz/rlz_extension_apitest.cc

@@ -19,14 +19,19 @@

#endif

class MockRlzSendFinancialPingFunction : public RlzSendFinancialPingFunction {

- virtual bool RunImpl();

- static int expected_count_;

public:

static int expected_count() {

return expected_count_;

}

+ protected:

+ virtual ~MockRlzSendFinancialPingFunction() {}

+ // ExtensionFunction

+ virtual bool RunImpl() OVERRIDE;

+ private:

+ static int expected_count_;

};

int MockRlzSendFinancialPingFunction::expected_count_ = 0;