Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5065)

Unified Diff: chrome/browser/rlz/rlz_extension_api.h

Issue 10071036: RefCounted types should not have public destructors, chrome/browser/ part 6 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Implementation fixes Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/rlz/rlz_extension_api.h
diff --git a/chrome/browser/rlz/rlz_extension_api.h b/chrome/browser/rlz/rlz_extension_api.h
index 15c58356a771922ea4ab1bedd299f5be0345d2a5..64199515f102b6c07a43e4377be05ef09f8d545d 100644
--- a/chrome/browser/rlz/rlz_extension_api.h
+++ b/chrome/browser/rlz/rlz_extension_api.h
@@ -15,23 +15,38 @@
#include "rlz/lib/lib_values.h"
class RlzRecordProductEventFunction : public SyncExtensionFunction {
- virtual bool RunImpl() OVERRIDE;
+ public:
DECLARE_EXTENSION_FUNCTION_NAME("experimental.rlz.recordProductEvent")
+
+ protected:
+ virtual ~RlzRecordProductEventFunction() {}
+
+ // ExtensionFunction:
+ virtual bool RunImpl() OVERRIDE;
};
class RlzGetAccessPointRlzFunction : public SyncExtensionFunction {
- virtual bool RunImpl() OVERRIDE;
+ public:
DECLARE_EXTENSION_FUNCTION_NAME("experimental.rlz.getAccessPointRlz")
+
+ protected:
+ virtual ~RlzGetAccessPointRlzFunction() {}
+
+ // ExtensionFunction:
+ virtual bool RunImpl() OVERRIDE;
};
class RlzSendFinancialPingFunction : public AsyncExtensionFunction {
public:
+ DECLARE_EXTENSION_FUNCTION_NAME("experimental.rlz.sendFinancialPing")
+
RlzSendFinancialPingFunction();
- virtual ~RlzSendFinancialPingFunction();
- DECLARE_EXTENSION_FUNCTION_NAME("experimental.rlz.sendFinancialPing")
- // Making this function protected so that it can be overridden in tests.
protected:
+ friend class MockRlzSendFinancialPingFunction;
+ virtual ~RlzSendFinancialPingFunction();
+
+ // ExtensionFunction:
virtual bool RunImpl() OVERRIDE;
private:
@@ -48,8 +63,14 @@ class RlzSendFinancialPingFunction : public AsyncExtensionFunction {
};
class RlzClearProductStateFunction : public SyncExtensionFunction {
- virtual bool RunImpl() OVERRIDE;
+ public:
DECLARE_EXTENSION_FUNCTION_NAME("experimental.rlz.clearProductState")
+
+ protected:
+ virtual ~RlzClearProductStateFunction() {}
+
+ // ExtensionFunction:
+ virtual bool RunImpl() OVERRIDE;
};
#endif // defined(OS_WIN) || defined(OS_MACOSX)
« no previous file with comments | « chrome/browser/renderer_host/plugin_info_message_filter.cc ('k') | chrome/browser/rlz/rlz_extension_apitest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698