chrome/browser/importer/external_process_importer_client.h - Issue 10071036: RefCounted types should not have public destructors, chrome/browser/ part 6

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/importer/external_process_importer_client.h

Issue 10071036: RefCounted types should not have public destructors, chrome/browser/ part 6 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Implementation fixes Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/geolocation/chrome_access_token_store.cc ('k') | chrome/browser/importer/external_process_importer_client.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/importer/external_process_importer_client.h

diff --git a/chrome/browser/importer/external_process_importer_client.h b/chrome/browser/importer/external_process_importer_client.h

index 1394588e3109c061592e3dd7a04b65b8e6d03ca4..ae13b817bae2d12740c352a9157fb22777474245 100644

--- a/chrome/browser/importer/external_process_importer_client.h

+++ b/chrome/browser/importer/external_process_importer_client.h

@@ -39,7 +39,6 @@ class ExternalProcessImporterClient : public content::UtilityProcessHostClient {

const importer::SourceProfile& source_profile,

uint16 items,

InProcessImporterBridge* bridge);

- virtual ~ExternalProcessImporterClient();

// Launches the task to start the external process.

void Start();

@@ -73,6 +72,9 @@ class ExternalProcessImporterClient : public content::UtilityProcessHostClient {

void OnKeywordsImportReady(const std::vector<TemplateURL*>& template_urls,

bool unique_on_host_and_path);

+ protected:

+ virtual ~ExternalProcessImporterClient();

private:

// Notifies the importerhost that import has finished, and calls Release().

void Cleanup();