Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Unified Diff: chrome/browser/geolocation/chrome_access_token_store.cc

Issue 10071036: RefCounted types should not have public destructors, chrome/browser/ part 6 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Implementation fixes Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/geolocation/chrome_access_token_store.cc
diff --git a/chrome/browser/geolocation/chrome_access_token_store.cc b/chrome/browser/geolocation/chrome_access_token_store.cc
index 7827e3d210ce3f11de9f2d0ec06d0394397cecd5..23297bc3b92c4f38b7c792aae32ba9b05ce69cbc 100644
--- a/chrome/browser/geolocation/chrome_access_token_store.cc
+++ b/chrome/browser/geolocation/chrome_access_token_store.cc
@@ -43,6 +43,10 @@ class TokenLoadingJob : public base::RefCountedThreadSafe<TokenLoadingJob> {
}
private:
+ friend class base::RefCountedThreadSafe<TokenLoadingJob>;
+
+ ~TokenLoadingJob() {}
+
void PerformWorkOnUIThread() {
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
DictionaryPrefUpdate update(g_browser_process->local_state(),
@@ -87,11 +91,7 @@ void ChromeAccessTokenStore::RegisterPrefs(PrefService* prefs) {
prefs->RegisterDictionaryPref(prefs::kGeolocationAccessToken);
}
-ChromeAccessTokenStore::ChromeAccessTokenStore() {
-}
-
-ChromeAccessTokenStore::~ChromeAccessTokenStore() {
-}
+ChromeAccessTokenStore::ChromeAccessTokenStore() {}
void ChromeAccessTokenStore::LoadAccessTokens(
const LoadAccessTokensCallbackType& callback) {
@@ -99,7 +99,10 @@ void ChromeAccessTokenStore::LoadAccessTokens(
job->Run();
}
-void SetAccessTokenOnUIThread(const GURL& server_url, const string16& token) {
+ChromeAccessTokenStore::~ChromeAccessTokenStore() {}
+
+static void SetAccessTokenOnUIThread(const GURL& server_url,
+ const string16& token) {
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
DictionaryPrefUpdate update(g_browser_process->local_state(),
prefs::kGeolocationAccessToken);
« no previous file with comments | « chrome/browser/geolocation/chrome_access_token_store.h ('k') | chrome/browser/importer/external_process_importer_client.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698