RefCounted types should not have public destructors, chrome/browser/ part 6

chrome/browser/geolocation/chrome_access_token_store.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/geolocation/chrome_access_token_store.h"
 
 #include "base/bind.h"
 #include "base/string_piece.h"
 #include "base/utf_string_conversions.h"
 #include "base/values.h"
@@ skipping 25 matching lines @@
 
   void Run() {
     BrowserThread::PostTaskAndReply(
         BrowserThread::UI,
         FROM_HERE,
         base::Bind(&TokenLoadingJob::PerformWorkOnUIThread, this),
         base::Bind(&TokenLoadingJob::RespondOnOriginatingThread, this));
   }
 
  private:
+  friend class base::RefCountedThreadSafe<TokenLoadingJob>;
+
+  ~TokenLoadingJob() {}
+
   void PerformWorkOnUIThread() {
     DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
     DictionaryPrefUpdate update(g_browser_process->local_state(),
                                 prefs::kGeolocationAccessToken);
     DictionaryValue* token_dictionary = update.Get();
 
     bool has_old_network_provider_url = false;
     // The dictionary value could be NULL if the pref has never been set.
     if (token_dictionary != NULL) {
       for (DictionaryValue::key_iterator it = token_dictionary->begin_keys();
@@ skipping 24 matching lines @@
   AccessTokenStore::AccessTokenSet access_token_set_;
   net::URLRequestContextGetter* system_request_context_;
 };
 
 }  // namespace
 
 void ChromeAccessTokenStore::RegisterPrefs(PrefService* prefs) {
   prefs->RegisterDictionaryPref(prefs::kGeolocationAccessToken);
 }
 
-ChromeAccessTokenStore::ChromeAccessTokenStore() {
-}
-
-ChromeAccessTokenStore::~ChromeAccessTokenStore() {
-}
+ChromeAccessTokenStore::ChromeAccessTokenStore() {}
 
 void ChromeAccessTokenStore::LoadAccessTokens(
     const LoadAccessTokensCallbackType& callback) {
   scoped_refptr<TokenLoadingJob> job(new TokenLoadingJob(callback));
   job->Run();
 }
 
-void SetAccessTokenOnUIThread(const GURL& server_url, const string16& token) {
+ChromeAccessTokenStore::~ChromeAccessTokenStore() {}
+
+static void SetAccessTokenOnUIThread(const GURL& server_url,
+                                     const string16& token) {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
   DictionaryPrefUpdate update(g_browser_process->local_state(),
                               prefs::kGeolocationAccessToken);
   DictionaryValue* access_token_dictionary = update.Get();
   access_token_dictionary->SetWithoutPathExpansion(
       server_url.spec(), Value::CreateStringValue(token));
 }
 
 void ChromeAccessTokenStore::SaveAccessToken(const GURL& server_url,
                                              const string16& access_token) {
   BrowserThread::PostTask(
       BrowserThread::UI, FROM_HERE,
       base::Bind(&SetAccessTokenOnUIThread, server_url, access_token));
 }