Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1634)

Unified Diff: chrome/browser/autocomplete/shortcuts_provider.cc

Issue 10071036: RefCounted types should not have public destructors, chrome/browser/ part 6 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Implementation fixes Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/autocomplete/shortcuts_provider.cc
diff --git a/chrome/browser/autocomplete/shortcuts_provider.cc b/chrome/browser/autocomplete/shortcuts_provider.cc
index 96bb9d1489353e88f5f24e0aa4dee69a2f98fd79..f03467d387b6538ccc9897815874985d364b6024 100644
--- a/chrome/browser/autocomplete/shortcuts_provider.cc
+++ b/chrome/browser/autocomplete/shortcuts_provider.cc
@@ -61,11 +61,6 @@ ShortcutsProvider::ShortcutsProvider(ACProviderListener* listener,
}
}
-ShortcutsProvider::~ShortcutsProvider() {
- if (shortcuts_backend_.get())
- shortcuts_backend_->RemoveObserver(this);
-}
-
void ShortcutsProvider::Start(const AutocompleteInput& input,
bool minimal_changes) {
matches_.clear();
@@ -111,6 +106,11 @@ void ShortcutsProvider::DeleteMatch(const AutocompleteMatch& match) {
history_service->DeleteURL(match.destination_url);
}
+ShortcutsProvider::~ShortcutsProvider() {
+ if (shortcuts_backend_.get())
+ shortcuts_backend_->RemoveObserver(this);
+}
+
void ShortcutsProvider::OnShortcutsLoaded() {
initialized_ = true;
}
« no previous file with comments | « chrome/browser/autocomplete/shortcuts_provider.h ('k') | chrome/browser/autocomplete_history_manager_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698