RefCounted types should not have public destructors, chrome/browser/ part 6

chrome/browser/autocomplete/shortcuts_provider.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/autocomplete/shortcuts_provider.h"
 
 #include <algorithm>
 #include <cmath>
 #include <map>
 #include <vector>
@@ skipping 43 matching lines @@
       languages_(profile_->GetPrefs()->GetString(prefs::kAcceptLanguages)),
       initialized_(false),
       shortcuts_backend_(profile->GetShortcutsBackend()) {
   if (shortcuts_backend_.get()) {
     shortcuts_backend_->AddObserver(this);
     if (shortcuts_backend_->initialized())
       initialized_ = true;
   }
 }
 
-ShortcutsProvider::~ShortcutsProvider() {
-  if (shortcuts_backend_.get())
-    shortcuts_backend_->RemoveObserver(this);
-}
-
 void ShortcutsProvider::Start(const AutocompleteInput& input,
                               bool minimal_changes) {
   matches_.clear();
 
   if (input.type() == AutocompleteInput::INVALID)
     return;
 
   if (input.text().empty())
     return;
 
@@ skipping 25 matching lines @@
 
   // Delete the match from the history DB. This will eventually result in a
   // second call to DeleteShortcutsWithURLs(), which is harmless.
   HistoryService* const history_service =
       profile_->GetHistoryService(Profile::EXPLICIT_ACCESS);
 
   DCHECK(history_service && match.destination_url.is_valid());
   history_service->DeleteURL(match.destination_url);
 }
 
+ShortcutsProvider::~ShortcutsProvider() {
+  if (shortcuts_backend_.get())
+    shortcuts_backend_->RemoveObserver(this);
+}
+
 void ShortcutsProvider::OnShortcutsLoaded() {
   initialized_ = true;
 }
 
 void ShortcutsProvider::DeleteMatchesWithURLs(const std::set<GURL>& urls) {
   std::remove_if(matches_.begin(), matches_.end(), RemoveMatchPredicate(urls));
   listener_->OnProviderUpdate(true);
 }
 
 void ShortcutsProvider::DeleteShortcutsWithURLs(const std::set<GURL>& urls) {
@@ skipping 178 matching lines @@
 }
 
 void ShortcutsProvider::set_shortcuts_backend(
     history::ShortcutsBackend* shortcuts_backend) {
   DCHECK(shortcuts_backend);
   shortcuts_backend_ = shortcuts_backend;
   shortcuts_backend_->AddObserver(this);
   if (shortcuts_backend_->initialized())
     initialized_ = true;
 }