Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(926)

Unified Diff: chrome/browser/extensions/api/extension_action/extension_page_actions_api.h

Issue 10071035: RefCounted types should not have public destructors, chrome/browser/extensions (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Implementations Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/extension_action/extension_page_actions_api.h
diff --git a/chrome/browser/extensions/api/extension_action/extension_page_actions_api.h b/chrome/browser/extensions/api/extension_action/extension_page_actions_api.h
index 899f395b309be78e10adb8d6d8bc31393967543f..0848c3c4228bf82b352de0aad43741207d061aaf 100644
--- a/chrome/browser/extensions/api/extension_action/extension_page_actions_api.h
+++ b/chrome/browser/extensions/api/extension_action/extension_page_actions_api.h
@@ -16,6 +16,8 @@ class PageActionFunction : public ExtensionActionFunction {
protected:
virtual ~PageActionFunction() {}
bool SetVisible(bool visible);
+
+ // ExtensionFunction:
virtual bool RunImpl() OVERRIDE;
TabContentsWrapper* contents_;
@@ -31,100 +33,170 @@ class PageActionsFunction : public SyncExtensionFunction {
// Implement chrome.pageActions.enableForTab().
class EnablePageActionsFunction : public PageActionsFunction {
+ public:
+ DECLARE_EXTENSION_FUNCTION_NAME("pageActions.enableForTab")
+
+ protected:
virtual ~EnablePageActionsFunction() {}
+
+ // ExtensionFunction:
virtual bool RunImpl() OVERRIDE;
- DECLARE_EXTENSION_FUNCTION_NAME("pageActions.enableForTab")
};
// Implement chrome.pageActions.disableForTab().
class DisablePageActionsFunction : public PageActionsFunction {
+ public:
+ DECLARE_EXTENSION_FUNCTION_NAME("pageActions.disableForTab")
+
+ protected:
virtual ~DisablePageActionsFunction() {}
+
+ // ExtensionFunction:
virtual bool RunImpl() OVERRIDE;
- DECLARE_EXTENSION_FUNCTION_NAME("pageActions.disableForTab")
};
// Implement chrome.pageAction.show().
class PageActionShowFunction : public PageActionFunction {
+ public:
+ DECLARE_EXTENSION_FUNCTION_NAME("pageAction.show")
+
+ protected:
virtual ~PageActionShowFunction() {}
+
+ // ExtensionActionFunction:
virtual bool RunExtensionAction() OVERRIDE;
- DECLARE_EXTENSION_FUNCTION_NAME("pageAction.show")
};
// Implement chrome.pageAction.hide().
class PageActionHideFunction : public PageActionFunction {
+ public:
+ DECLARE_EXTENSION_FUNCTION_NAME("pageAction.hide")
+
+ protected:
virtual ~PageActionHideFunction() {}
+
+ // ExtensionActionFunction:
virtual bool RunExtensionAction() OVERRIDE;
- DECLARE_EXTENSION_FUNCTION_NAME("pageAction.hide")
};
// Implement chrome.pageAction.setIcon().
class PageActionSetIconFunction : public PageActionFunction {
+ public:
+ DECLARE_EXTENSION_FUNCTION_NAME("pageAction.setIcon")
+
+ protected:
virtual ~PageActionSetIconFunction() {}
+
+ // ExtensionActionFunction:
virtual bool RunExtensionAction() OVERRIDE;
- DECLARE_EXTENSION_FUNCTION_NAME("pageAction.setIcon")
};
// Implement chrome.pageAction.setTitle().
class PageActionSetTitleFunction : public PageActionFunction {
+ public:
+ DECLARE_EXTENSION_FUNCTION_NAME("pageAction.setTitle")
+
+ protected:
virtual ~PageActionSetTitleFunction() {}
+
+ // ExtensionActionFunction:
virtual bool RunExtensionAction() OVERRIDE;
- DECLARE_EXTENSION_FUNCTION_NAME("pageAction.setTitle")
};
// Implement chrome.pageAction.setPopup().
class PageActionSetPopupFunction : public PageActionFunction {
+ public:
+ DECLARE_EXTENSION_FUNCTION_NAME("pageAction.setPopup")
+
+ protected:
virtual ~PageActionSetPopupFunction() {}
+
+ // ExtensionActionFunction:
virtual bool RunExtensionAction() OVERRIDE;
- DECLARE_EXTENSION_FUNCTION_NAME("pageAction.setPopup")
};
// Implement chrome.pageAction.setBadgeBackgroundColor().
class PageActionSetBadgeBackgroundColorFunction : public PageActionFunction {
+ public:
+ DECLARE_EXTENSION_FUNCTION_NAME("pageAction.setBadgeBackgroundColor")
+
+ protected:
virtual ~PageActionSetBadgeBackgroundColorFunction() {}
+
+ // ExtensionActionFunction:
virtual bool RunExtensionAction() OVERRIDE;
- DECLARE_EXTENSION_FUNCTION_NAME("pageAction.setBadgeBackgroundColor")
};
// Implement chrome.pageAction.setBadgeTextColor().
class PageActionSetBadgeTextColorFunction : public PageActionFunction {
+ public:
+ DECLARE_EXTENSION_FUNCTION_NAME("pageAction.setBadgeTextColor")
+
+ protected:
virtual ~PageActionSetBadgeTextColorFunction() {}
+
+ // ExtensionActionFunction:
virtual bool RunExtensionAction() OVERRIDE;
- DECLARE_EXTENSION_FUNCTION_NAME("pageAction.setBadgeTextColor")
};
// Implement chrome.pageActions.setBadgeText().
class PageActionSetBadgeTextFunction : public PageActionFunction {
+ public:
+ DECLARE_EXTENSION_FUNCTION_NAME("pageAction.setBadgeText")
+
+ protected:
virtual ~PageActionSetBadgeTextFunction() {}
+
+ // ExtensionActionFunction:
virtual bool RunExtensionAction() OVERRIDE;
- DECLARE_EXTENSION_FUNCTION_NAME("pageAction.setBadgeText")
};
// Implement chrome.pageAction.getTitle().
class PageActionGetTitleFunction : public PageActionFunction {
+ public:
+ DECLARE_EXTENSION_FUNCTION_NAME("pageAction.getTitle")
+
+ protected:
virtual ~PageActionGetTitleFunction() {}
+
+ // ExtensionActionFunction:
virtual bool RunExtensionAction() OVERRIDE;
- DECLARE_EXTENSION_FUNCTION_NAME("pageAction.getTitle")
};
// Implement chrome.pageAction.getPopup().
class PageActionGetPopupFunction : public PageActionFunction {
+ public:
+ DECLARE_EXTENSION_FUNCTION_NAME("pageAction.getPopup")
+
+ protected:
virtual ~PageActionGetPopupFunction() {}
+
+ // ExtensionActionFunction:
virtual bool RunExtensionAction() OVERRIDE;
- DECLARE_EXTENSION_FUNCTION_NAME("pageAction.getPopup")
};
// Implement chrome.pageAction.getBadgeText().
class PageActionGetBadgeTextFunction : public PageActionFunction {
+ public:
+ DECLARE_EXTENSION_FUNCTION_NAME("pageAction.getBadgeText")
+
+ protected:
virtual ~PageActionGetBadgeTextFunction() {}
+
+ // ExtensionActionFunction:
virtual bool RunExtensionAction() OVERRIDE;
- DECLARE_EXTENSION_FUNCTION_NAME("pageAction.getBadgeText")
};
// Implement chrome.pageAction.getBadgeBackgroundColor().
class PageActionGetBadgeBackgroundColorFunction : public PageActionFunction {
+ public:
+ DECLARE_EXTENSION_FUNCTION_NAME("pageAction.getBadgeBackgroundColor")
+
+ protected:
virtual ~PageActionGetBadgeBackgroundColorFunction() {}
+
+ // ExtensionActionFunction:
virtual bool RunExtensionAction() OVERRIDE;
- DECLARE_EXTENSION_FUNCTION_NAME("pageAction.getBadgeBackgroundColor")
};
#endif // CHROME_BROWSER_EXTENSIONS_API_EXTENSION_ACTION_EXTENSION_PAGE_ACTIONS_API_H_

Powered by Google App Engine
This is Rietveld 408576698