Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3971)

Unified Diff: chrome/browser/extensions/api/extension_action/extension_browser_actions_api.h

Issue 10071035: RefCounted types should not have public destructors, chrome/browser/extensions (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Implementations Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/extension_action/extension_browser_actions_api.h
diff --git a/chrome/browser/extensions/api/extension_action/extension_browser_actions_api.h b/chrome/browser/extensions/api/extension_action/extension_browser_actions_api.h
index 1ead6912b44c037c96115c6d095c617dd784bc71..3724b31f32b5f4e41a112a6e5eaaa5bf4ad41dc6 100644
--- a/chrome/browser/extensions/api/extension_action/extension_browser_actions_api.h
+++ b/chrome/browser/extensions/api/extension_action/extension_browser_actions_api.h
@@ -14,73 +14,120 @@
class BrowserActionFunction : public ExtensionActionFunction {
protected:
virtual ~BrowserActionFunction() {}
+
+ // ExtensionFunction:
virtual bool RunImpl() OVERRIDE;
void FireUpdateNotification();
};
// Implement chrome.browserAction.setIcon().
class BrowserActionSetIconFunction : public BrowserActionFunction {
+ public:
+ DECLARE_EXTENSION_FUNCTION_NAME("browserAction.setIcon")
+
+ protected:
virtual ~BrowserActionSetIconFunction() {}
+
+ // ExtensionActionFunction:
virtual bool RunExtensionAction() OVERRIDE;
- DECLARE_EXTENSION_FUNCTION_NAME("browserAction.setIcon")
};
// Implement chrome.browserAction.setTitle().
class BrowserActionSetTitleFunction : public BrowserActionFunction {
+ public:
+ DECLARE_EXTENSION_FUNCTION_NAME("browserAction.setTitle")
+
+ protected:
virtual ~BrowserActionSetTitleFunction() {}
+
+ // ExtensionActionFunction:
virtual bool RunExtensionAction() OVERRIDE;
- DECLARE_EXTENSION_FUNCTION_NAME("browserAction.setTitle")
};
// Implement chrome.browserAction.setPopup().
class BrowserActionSetPopupFunction : public BrowserActionFunction {
+ public:
+ DECLARE_EXTENSION_FUNCTION_NAME("browserAction.setPopup")
+
+ protected:
virtual ~BrowserActionSetPopupFunction() {}
+
+ // ExtensionActionFunction:
virtual bool RunExtensionAction() OVERRIDE;
- DECLARE_EXTENSION_FUNCTION_NAME("browserAction.setPopup")
};
// Implement chrome.browserAction.setBadgeText().
class BrowserActionSetBadgeTextFunction : public BrowserActionFunction {
+ public:
+ DECLARE_EXTENSION_FUNCTION_NAME("browserAction.setBadgeText")
+
+ protected:
virtual ~BrowserActionSetBadgeTextFunction() {}
+
+ // ExtensionActionFunction:
virtual bool RunExtensionAction() OVERRIDE;
- DECLARE_EXTENSION_FUNCTION_NAME("browserAction.setBadgeText")
};
// Implement chrome.browserAction.setBadgeBackgroundColor().
class BrowserActionSetBadgeBackgroundColorFunction
: public BrowserActionFunction {
+ public:
+ DECLARE_EXTENSION_FUNCTION_NAME("browserAction.setBadgeBackgroundColor")
+
+ protected:
virtual ~BrowserActionSetBadgeBackgroundColorFunction() {}
+
+ // ExtensionActionFunction:
virtual bool RunExtensionAction() OVERRIDE;
- DECLARE_EXTENSION_FUNCTION_NAME("browserAction.setBadgeBackgroundColor")
};
// Implement chrome.browserAction.getTitle().
class BrowserActionGetTitleFunction : public BrowserActionFunction {
+ public:
+ DECLARE_EXTENSION_FUNCTION_NAME("browserAction.getTitle")
+
+ protected:
virtual ~BrowserActionGetTitleFunction() {}
+
+ // ExtensionActionFunction:
virtual bool RunExtensionAction() OVERRIDE;
- DECLARE_EXTENSION_FUNCTION_NAME("browserAction.getTitle")
};
// Implement chrome.browserAction.getPopup().
class BrowserActionGetPopupFunction : public BrowserActionFunction {
+ public:
+ DECLARE_EXTENSION_FUNCTION_NAME("browserAction.getPopup")
+
+ protected:
virtual ~BrowserActionGetPopupFunction() {}
+
+ // ExtensionActionFunction:
virtual bool RunExtensionAction() OVERRIDE;
- DECLARE_EXTENSION_FUNCTION_NAME("browserAction.getPopup")
};
// Implement chrome.browserAction.getBadgeText().
class BrowserActionGetBadgeTextFunction : public BrowserActionFunction {
+ public:
+ DECLARE_EXTENSION_FUNCTION_NAME("browserAction.getBadgeText")
+
+ protected:
virtual ~BrowserActionGetBadgeTextFunction() {}
+
+ // ExtensionActionFunction:
virtual bool RunExtensionAction() OVERRIDE;
- DECLARE_EXTENSION_FUNCTION_NAME("browserAction.getBadgeText")
};
// Implement chrome.browserAction.getBadgeBackgroundColor().
class BrowserActionGetBadgeBackgroundColorFunction
: public BrowserActionFunction {
+ public:
+ DECLARE_EXTENSION_FUNCTION_NAME("browserAction.getBadgeBackgroundColor")
+
+ protected:
virtual ~BrowserActionGetBadgeBackgroundColorFunction() {}
+
+ // ExtensionActionFunction:
virtual bool RunExtensionAction() OVERRIDE;
- DECLARE_EXTENSION_FUNCTION_NAME("browserAction.getBadgeBackgroundColor")
};
#endif // CHROME_BROWSER_EXTENSIONS_API_EXTENSION_ACTION_EXTENSION_BROWSER_ACTIONS_API_H_

Powered by Google App Engine
This is Rietveld 408576698