Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3188)

Unified Diff: chrome/browser/sync/glue/browser_thread_model_worker.cc

Issue 10071033: RefCounted types should not have public destructors, chrome/browser/ part 2 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Implementation ordering fixes as well Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/glue/browser_thread_model_worker.cc
diff --git a/chrome/browser/sync/glue/browser_thread_model_worker.cc b/chrome/browser/sync/glue/browser_thread_model_worker.cc
index 8fe5ebf8484a726d8339216fb68b18af927e9c0b..6b114950f8732390cc298ae607dc6f19c5411acc 100644
--- a/chrome/browser/sync/glue/browser_thread_model_worker.cc
+++ b/chrome/browser/sync/glue/browser_thread_model_worker.cc
@@ -15,9 +15,8 @@ namespace browser_sync {
BrowserThreadModelWorker::BrowserThreadModelWorker(
BrowserThread::ID thread, ModelSafeGroup group)
- : thread_(thread), group_(group) {}
-
-BrowserThreadModelWorker::~BrowserThreadModelWorker() {}
+ : thread_(thread), group_(group) {
+}
SyncerError BrowserThreadModelWorker::DoWorkAndWaitUntilDone(
const WorkCallback& work) {
@@ -39,6 +38,12 @@ SyncerError BrowserThreadModelWorker::DoWorkAndWaitUntilDone(
return error;
}
+ModelSafeGroup BrowserThreadModelWorker::GetModelSafeGroup() {
+ return group_;
+}
+
+BrowserThreadModelWorker::~BrowserThreadModelWorker() {}
+
void BrowserThreadModelWorker::CallDoWorkAndSignalTask(
const WorkCallback& work,
WaitableEvent* done,
@@ -48,14 +53,9 @@ void BrowserThreadModelWorker::CallDoWorkAndSignalTask(
done->Signal();
}
-ModelSafeGroup BrowserThreadModelWorker::GetModelSafeGroup() {
- return group_;
-}
-
DatabaseModelWorker::DatabaseModelWorker()
- : BrowserThreadModelWorker(BrowserThread::DB, GROUP_DB) {}
-
-DatabaseModelWorker::~DatabaseModelWorker() {}
+ : BrowserThreadModelWorker(BrowserThread::DB, GROUP_DB) {
+}
void DatabaseModelWorker::CallDoWorkAndSignalTask(
const WorkCallback& work,
@@ -64,10 +64,11 @@ void DatabaseModelWorker::CallDoWorkAndSignalTask(
BrowserThreadModelWorker::CallDoWorkAndSignalTask(work, done, error);
}
-FileModelWorker::FileModelWorker()
- : BrowserThreadModelWorker(BrowserThread::FILE, GROUP_FILE) {}
+DatabaseModelWorker::~DatabaseModelWorker() {}
-FileModelWorker::~FileModelWorker() {}
+FileModelWorker::FileModelWorker()
+ : BrowserThreadModelWorker(BrowserThread::FILE, GROUP_FILE) {
+}
void FileModelWorker::CallDoWorkAndSignalTask(
const WorkCallback& work,
@@ -76,4 +77,6 @@ void FileModelWorker::CallDoWorkAndSignalTask(
BrowserThreadModelWorker::CallDoWorkAndSignalTask(work, done, error);
}
+FileModelWorker::~FileModelWorker() {}
+
} // namespace browser_sync
« no previous file with comments | « chrome/browser/sync/glue/browser_thread_model_worker.h ('k') | chrome/browser/sync/glue/data_type_controller.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698