chrome/browser/history/top_sites.cc - Issue 10071032: RefCounted types should not have public destructors, chrome/browser/ part 1

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/history/top_sites.cc

Issue 10071032: RefCounted types should not have public destructors, chrome/browser/ part 1 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Implementation fixes Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/history/top_sites.cc

diff --git a/chrome/browser/history/top_sites.cc b/chrome/browser/history/top_sites.cc

index 8d1e59aca64147e2521b98e64246c21372fee9d3..0648415c0cd7ad598b2df16f2119248edb5d3112 100644

--- a/chrome/browser/history/top_sites.cc

+++ b/chrome/browser/history/top_sites.cc

@@ -115,6 +115,8 @@ class LoadThumbnailsFromHistoryTask : public HistoryDBTask {

}

private:

+ virtual ~LoadThumbnailsFromHistoryTask() {}

bool ShouldFetchThumbnailFor(const GURL& url) {

return ignore_urls_.find(url.spec()) == ignore_urls_.end();

}

« no previous file with comments | « chrome/browser/history/shortcuts_database.cc ('k') | chrome/browser/history/top_sites_extension_api.h » ('j') | no next file with comments »