Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Side by Side Diff: chrome/browser/history/top_sites.cc

Issue 10071032: RefCounted types should not have public destructors, chrome/browser/ part 1 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Implementation fixes Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/history/top_sites.h" 5 #include "chrome/browser/history/top_sites.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <set> 8 #include <set>
9 9
10 #include "base/bind.h" 10 #include "base/bind.h"
(...skipping 97 matching lines...) Expand 10 before | Expand all | Expand 10 after
108 } 108 }
109 } 109 }
110 return true; 110 return true;
111 } 111 }
112 112
113 virtual void DoneRunOnMainThread() { 113 virtual void DoneRunOnMainThread() {
114 top_sites_->FinishHistoryMigration(data_); 114 top_sites_->FinishHistoryMigration(data_);
115 } 115 }
116 116
117 private: 117 private:
118 virtual ~LoadThumbnailsFromHistoryTask() {}
119
118 bool ShouldFetchThumbnailFor(const GURL& url) { 120 bool ShouldFetchThumbnailFor(const GURL& url) {
119 return ignore_urls_.find(url.spec()) == ignore_urls_.end(); 121 return ignore_urls_.find(url.spec()) == ignore_urls_.end();
120 } 122 }
121 123
122 // Set of URLs we don't load thumbnails for. This is created on the UI thread 124 // Set of URLs we don't load thumbnails for. This is created on the UI thread
123 // and used on the history thread. 125 // and used on the history thread.
124 std::set<std::string> ignore_urls_; 126 std::set<std::string> ignore_urls_;
125 127
126 scoped_refptr<TopSites> top_sites_; 128 scoped_refptr<TopSites> top_sites_;
127 129
(...skipping 765 matching lines...) Expand 10 before | Expand all | Expand 10 after
893 SetTopSites(pages); 895 SetTopSites(pages);
894 896
895 // Used only in testing. 897 // Used only in testing.
896 content::NotificationService::current()->Notify( 898 content::NotificationService::current()->Notify(
897 chrome::NOTIFICATION_TOP_SITES_UPDATED, 899 chrome::NOTIFICATION_TOP_SITES_UPDATED,
898 content::Source<TopSites>(this), 900 content::Source<TopSites>(this),
899 content::Details<CancelableRequestProvider::Handle>(&handle)); 901 content::Details<CancelableRequestProvider::Handle>(&handle));
900 } 902 }
901 903
902 } // namespace history 904 } // namespace history
OLDNEW
« no previous file with comments | « chrome/browser/history/shortcuts_database.cc ('k') | chrome/browser/history/top_sites_extension_api.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698