chrome/browser/history/history_types.h - Issue 10071032: RefCounted types should not have public destructors, chrome/browser/ part 1

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/history/history_types.h

Issue 10071032: RefCounted types should not have public destructors, chrome/browser/ part 1 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Implementation fixes Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/history/history_types.h

diff --git a/chrome/browser/history/history_types.h b/chrome/browser/history/history_types.h

index 5cd4ce6b14361efb462ada43ace72edcd91336cc..050e528eadf8e84b6ea469ff2a5146251189451f 100644

--- a/chrome/browser/history/history_types.h

+++ b/chrome/browser/history/history_types.h

@@ -682,13 +682,13 @@ class MostVisitedThumbnails

: public base::RefCountedThreadSafe<MostVisitedThumbnails> {

public:

MostVisitedThumbnails();

- virtual ~MostVisitedThumbnails();

MostVisitedURLList most_visited;

URLToImagesMap url_to_images_map;

private:

friend class base::RefCountedThreadSafe<MostVisitedThumbnails>;

+ virtual ~MostVisitedThumbnails();

DISALLOW_COPY_AND_ASSIGN(MostVisitedThumbnails);

};

« no previous file with comments | « chrome/browser/history/history_extension_api.h ('k') | chrome/browser/history/in_memory_url_index.h » ('j') | no next file with comments »