RefCounted types should not have public destructors, chrome/browser/ part 1

chrome/browser/history/history_extension_api.h

Index: chrome/browser/history/history_extension_api.h
diff --git a/chrome/browser/history/history_extension_api.h b/chrome/browser/history/history_extension_api.h
index e66ea76882ed063d6a6119c07cd09246fffe799f..5f57551273b1c278ee74ec878428328edce7533c 100644
--- a/chrome/browser/history/history_extension_api.h
+++ b/chrome/browser/history/history_extension_api.h
@@ -48,9 +48,9 @@ class HistoryExtensionEventRouter : public content::NotificationObserver {
 
 // Base class for history function APIs.
 class HistoryFunction : public AsyncExtensionFunction {
- public:
+ protected:
+  virtual ~HistoryFunction() {}
   virtual void Run() OVERRIDE;
-  virtual bool RunImpl() = 0;
 
   bool GetUrlFromValue(base::Value* value, GURL* url);
   bool GetTimeFromValue(base::Value* value, base::Time* time);
@@ -61,8 +61,13 @@ class HistoryFunction : public AsyncExtensionFunction {
 class HistoryFunctionWithCallback : public HistoryFunction {
  public:
   HistoryFunctionWithCallback();
+
+ protected:
   virtual ~HistoryFunctionWithCallback();
 
+  // ExtensionFunction:
+  virtual bool RunImpl() OVERRIDE;
+
   // Return true if the async call was completed, false otherwise.
   virtual bool RunAsyncImpl() = 0;
 
@@ -70,10 +75,6 @@ class HistoryFunctionWithCallback : public HistoryFunction {
   // This method calls Release().
   virtual void SendAsyncResponse();
 
-  // Override HistoryFunction::RunImpl.
-  virtual bool RunImpl() OVERRIDE;
-
- protected:
   // The consumer for the HistoryService callbacks.
   CancelableRequestConsumer cancelable_consumer_;
 
@@ -85,10 +86,14 @@ class HistoryFunctionWithCallback : public HistoryFunction {
 
 class GetVisitsHistoryFunction : public HistoryFunctionWithCallback {
  public:
-  // Override HistoryFunction.
-  virtual bool RunAsyncImpl() OVERRIDE;
   DECLARE_EXTENSION_FUNCTION_NAME("history.getVisits");
 
+ protected:
+  virtual ~GetVisitsHistoryFunction() {}
+
+  // HistoryFunctionWithCallback:
+  virtual bool RunAsyncImpl() OVERRIDE;
+
   // Callback for the history function to provide results.
   void QueryComplete(HistoryService::Handle request_service,
                      bool success,
@@ -98,9 +103,14 @@ class GetVisitsHistoryFunction : public HistoryFunctionWithCallback {
 
 class SearchHistoryFunction : public HistoryFunctionWithCallback {
  public:
-  virtual bool RunAsyncImpl() OVERRIDE;
   DECLARE_EXTENSION_FUNCTION_NAME("history.search");
 
+ protected:
+  virtual ~SearchHistoryFunction() {}
+
+  // HistoryFunctionWithCallback:
+  virtual bool RunAsyncImpl() OVERRIDE;
+
   // Callback for the history function to provide results.
   void SearchComplete(HistoryService::Handle request_handle,
                       history::QueryResults* results);
@@ -108,15 +118,25 @@ class SearchHistoryFunction : public HistoryFunctionWithCallback {
 
 class AddUrlHistoryFunction : public HistoryFunction {
  public:
-  virtual bool RunImpl() OVERRIDE;
   DECLARE_EXTENSION_FUNCTION_NAME("history.addUrl");
+
+ protected:
+  virtual ~AddUrlHistoryFunction() {}
+
+  // HistoryFunctionWithCallback:
+  virtual bool RunImpl() OVERRIDE;
 };
 
 class DeleteAllHistoryFunction : public HistoryFunctionWithCallback {
  public:
-  virtual bool RunAsyncImpl() OVERRIDE;
   DECLARE_EXTENSION_FUNCTION_NAME("history.deleteAll");
 
+ protected:
+  virtual ~DeleteAllHistoryFunction() {}
+
+  // HistoryFunctionWithCallback:
+  virtual bool RunAsyncImpl() OVERRIDE;
+
   // Callback for the history service to acknowledge deletion.
   void DeleteComplete();
 };
@@ -124,15 +144,25 @@ class DeleteAllHistoryFunction : public HistoryFunctionWithCallback {
 
 class DeleteUrlHistoryFunction : public HistoryFunction {
  public:
-  virtual bool RunImpl() OVERRIDE;
   DECLARE_EXTENSION_FUNCTION_NAME("history.deleteUrl");
+
+ protected:
+  virtual ~DeleteUrlHistoryFunction() {}
+
+  // HistoryFunctionWithCallback:
+  virtual bool RunImpl() OVERRIDE;
 };
 
 class DeleteRangeHistoryFunction : public HistoryFunctionWithCallback {
  public:
-  virtual bool RunAsyncImpl() OVERRIDE;
   DECLARE_EXTENSION_FUNCTION_NAME("history.deleteRange");
 
+ protected:
+  virtual ~DeleteRangeHistoryFunction() {}
+
+  // HistoryFunctionWithCallback:
+  virtual bool RunAsyncImpl() OVERRIDE;
+
   // Callback for the history service to acknowledge deletion.
   void DeleteComplete();
 };