chrome/browser/history/shortcuts_database.h - Issue 10071032: RefCounted types should not have public destructors, chrome/browser/ part 1

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/history/shortcuts_database.h

Issue 10071032: RefCounted types should not have public destructors, chrome/browser/ part 1 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/history/shortcuts_backend.h ('K') | « chrome/browser/history/shortcuts_backend.h ('k') | chrome/browser/history/top_sites.cc » ('j') | chrome/browser/net/sqlite_persistent_cookie_store.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/history/shortcuts_database.h

diff --git a/chrome/browser/history/shortcuts_database.h b/chrome/browser/history/shortcuts_database.h

index 2d73d22696cb2a20dcbd6f36bdded5d83f1889ba..11d4caac9e8817af7b6d65afd134d1e59faf840d 100644

--- a/chrome/browser/history/shortcuts_database.h

+++ b/chrome/browser/history/shortcuts_database.h

@@ -43,7 +43,6 @@ class ShortcutsDatabase : public base::RefCountedThreadSafe<ShortcutsDatabase> {

typedef std::map<std::string, ShortcutsBackend::Shortcut> GuidToShortcutMap;

explicit ShortcutsDatabase(const FilePath& folder_path);

- virtual ~ShortcutsDatabase();

bool Init();

@@ -66,6 +65,10 @@ class ShortcutsDatabase : public base::RefCountedThreadSafe<ShortcutsDatabase> {

bool LoadShortcuts(GuidToShortcutMap* shortcuts);

private:

+ friend class base::RefCountedThreadSafe<ShortcutsDatabase>;

+ virtual ~ShortcutsDatabase();

sky 2012/04/13 15:50:52 Move implementation to match.

// Ensures that the table is present.

bool EnsureTable();