RefCounted types should not have public destructors, chrome/browser/ part 1

chrome/browser/history/shortcuts_database.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_HISTORY_SHORTCUTS_DATABASE_H_
 #define CHROME_BROWSER_HISTORY_SHORTCUTS_DATABASE_H_
 #pragma once
 
 #include <map>
 #include <string>
@@ skipping 25 matching lines @@
 //   description_matches Comma separated matches of the |search_text| in
 //                       |description|.
 //   last_access_time    Time the entry was accessed last, stored in seconds,
 //                       UTC.
 //   number_of_hits      Number of times that the entry has been selected.
 class ShortcutsDatabase : public base::RefCountedThreadSafe<ShortcutsDatabase> {
  public:
   typedef std::map<std::string, ShortcutsBackend::Shortcut> GuidToShortcutMap;
 
   explicit ShortcutsDatabase(const FilePath& folder_path);
-  virtual ~ShortcutsDatabase();
 
   bool Init();
 
   // Adds the ShortcutsProvider::Shortcut to the database.
   bool AddShortcut(const ShortcutsBackend::Shortcut& shortcut);
 
   // Updates timing and selection count for the ShortcutsProvider::Shortcut.
   bool UpdateShortcut(const ShortcutsBackend::Shortcut& shortcut);
 
   // Deletes the ShortcutsProvider::Shortcuts with the id.
   bool DeleteShortcutsWithIds(const std::vector<std::string>& shortcut_ids);
 
   // Deletes the ShortcutsProvider::Shortcuts with the url.
   bool DeleteShortcutsWithUrl(const std::string& shortcut_url_spec);
 
   // Deletes all of the ShortcutsProvider::Shortcuts.
   bool DeleteAllShortcuts();
 
   // Loads all of the shortcuts.
   bool LoadShortcuts(GuidToShortcutMap* shortcuts);
 
  private:
+  friend class base::RefCountedThreadSafe<ShortcutsDatabase>;
+
+  virtual ~ShortcutsDatabase();

[sky, 2012/04/13 15:50:52]

Move implementation to match.

+
   // Ensures that the table is present.
   bool EnsureTable();
 
   friend class ShortcutsDatabaseTest;
   FRIEND_TEST_ALL_PREFIXES(ShortcutsDatabaseTest, AddShortcut);
   FRIEND_TEST_ALL_PREFIXES(ShortcutsDatabaseTest, UpdateShortcut);
   FRIEND_TEST_ALL_PREFIXES(ShortcutsDatabaseTest, DeleteShortcutsWithIds);
   FRIEND_TEST_ALL_PREFIXES(ShortcutsDatabaseTest, DeleteShortcutsWithUrl);
   FRIEND_TEST_ALL_PREFIXES(ShortcutsDatabaseTest, LoadShortcuts);
 
   // The sql database. Not valid until Init is called.
   sql::Connection db_;
   FilePath database_path_;
 
   static const FilePath::CharType kShortcutsDatabaseName[];
 
   DISALLOW_COPY_AND_ASSIGN(ShortcutsDatabase);
 };
 
 }  // namespace history
 
 #endif  // CHROME_BROWSER_HISTORY_SHORTCUTS_DATABASE_H_