RefCounted types should not have public destructors, chrome/browser/ part 1

chrome/browser/history/history_browsertest.cc

Index: chrome/browser/history/history_browsertest.cc
diff --git a/chrome/browser/history/history_browsertest.cc b/chrome/browser/history/history_browsertest.cc
index 272dbbb1dbb30e4a0f85233267aa43b736a036da..453f59c23b68d220dce1d8de30247bf94eb92acd 100644
--- a/chrome/browser/history/history_browsertest.cc
+++ b/chrome/browser/history/history_browsertest.cc
@@ -30,8 +30,7 @@ namespace {
 // Notifies the main thread after all history backend thread tasks have run.
 class WaitForHistoryTask : public HistoryDBTask {
  public:
-  WaitForHistoryTask() {
-  }
+  WaitForHistoryTask() {}
 
   virtual bool RunOnDBThread(history::HistoryBackend* backend,
                              history::HistoryDatabase* db) {
@@ -43,6 +42,8 @@ class WaitForHistoryTask : public HistoryDBTask {
   }
 
  private:
+  virtual ~WaitForHistoryTask() {}

[sky, 2012/04/13 15:50:52]

There are subclasses of this class. Won't this need to be protected?

[Ryan Sleevi, 2012/04/13 19:00:25]

There are no subclasses. This is just in this unittest

+
   DISALLOW_COPY_AND_ASSIGN(WaitForHistoryTask);
 };