RefCounted types should not have public destructors, chrome/browser/ part 1

chrome/browser/history/history_browsertest.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <vector>
 
 #include "base/bind.h"
 #include "base/message_loop.h"
 #include "chrome/browser/history/history.h"
 #include "chrome/browser/prefs/pref_service.h"
@@ skipping 12 matching lines @@
 // Note: WaitableEvent is not used for synchronization between the main thread
 // and history backend thread because the history subsystem posts tasks back
 // to the main thread. Had we tried to Signal an event in such a task
 // and Wait for it on the main thread, the task would not run at all because
 // the main thread would be blocked on the Wait call, resulting in a deadlock.
 
 // A task to be scheduled on the history backend thread.
 // Notifies the main thread after all history backend thread tasks have run.
 class WaitForHistoryTask : public HistoryDBTask {
  public:
-  WaitForHistoryTask() {
-  }
+  WaitForHistoryTask() {}
 
   virtual bool RunOnDBThread(history::HistoryBackend* backend,
                              history::HistoryDatabase* db) {
     return true;
   }
 
   virtual void DoneRunOnMainThread() {
     MessageLoop::current()->Quit();
   }
 
  private:
+  virtual ~WaitForHistoryTask() {}

[sky, 2012/04/13 15:50:52]

There are subclasses of this class. Won't this need to be protected?

[Ryan Sleevi, 2012/04/13 19:00:25]

There are no subclasses. This is just in this unittest

+
   DISALLOW_COPY_AND_ASSIGN(WaitForHistoryTask);
 };
 
 // Enumerates all history contents on the backend thread.
 class HistoryEnumerator : public HistoryService::URLEnumerator {
  public:
   explicit HistoryEnumerator(HistoryService* history) {
     EXPECT_TRUE(history);
     if (!history)
       return;
@@ skipping 148 matching lines @@
   WaitForHistoryBackendToRun();
 
   {
     std::vector<GURL> urls(GetHistoryContents());
     ASSERT_EQ(1U, urls.size());
     EXPECT_EQ(GetTestUrl().spec(), urls[0].spec());
   }
 }
 
 }  // namespace