chrome/browser/net/sqlite_persistent_cookie_store.h - Issue 10071032: RefCounted types should not have public destructors, chrome/browser/ part 1

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/net/sqlite_persistent_cookie_store.h

Issue 10071032: RefCounted types should not have public destructors, chrome/browser/ part 1 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/history/shortcuts_database.h ('K') | « chrome/browser/net/crl_set_fetcher.h ('k') | chrome/browser/net/sqlite_persistent_cookie_store_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/net/sqlite_persistent_cookie_store.h

diff --git a/chrome/browser/net/sqlite_persistent_cookie_store.h b/chrome/browser/net/sqlite_persistent_cookie_store.h

index 08ee08e10749ef63d95f1c54554c653843594295..f3212fb8b0f502448eaf9d58941a916ed798a776 100644

--- a/chrome/browser/net/sqlite_persistent_cookie_store.h

+++ b/chrome/browser/net/sqlite_persistent_cookie_store.h

@@ -27,7 +27,6 @@ class SQLitePersistentCookieStore

public:

SQLitePersistentCookieStore(const FilePath& path,

bool restore_old_session_cookies);

- virtual ~SQLitePersistentCookieStore();

virtual void Load(const LoadedCallback& loaded_callback) OVERRIDE;

@@ -50,6 +49,8 @@ class SQLitePersistentCookieStore

private:

class Backend;

+ virtual ~SQLitePersistentCookieStore();

eroman 2012/04/13 18:47:25 Is it intentional that these lack implementations?

Ryan Sleevi 2012/04/13 18:52:35 The implementation is in the .cc file. All that ch

eroman 2012/04/13 19:26:38 oops, misread that!

scoped_refptr<Backend> backend_;

DISALLOW_COPY_AND_ASSIGN(SQLitePersistentCookieStore);