RefCounted types should not have public destructors, chrome/browser/ part 1

chrome/browser/net/sqlite_persistent_cookie_store.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // A sqlite implementation of a cookie monster persistent store.
 
 #ifndef CHROME_BROWSER_NET_SQLITE_PERSISTENT_COOKIE_STORE_H_
 #define CHROME_BROWSER_NET_SQLITE_PERSISTENT_COOKIE_STORE_H_
 #pragma once
 
 #include <string>
 #include <vector>
 
 #include "base/callback_forward.h"
 #include "base/compiler_specific.h"
 #include "base/memory/ref_counted.h"
 #include "net/cookies/cookie_monster.h"
 
 class FilePath;
 class Task;
 
 // Implements the PersistentCookieStore interface in terms of a SQLite database.
 // For documentation about the actual member functions consult the documentation
 // of the parent class |net::CookieMonster::PersistentCookieStore|.
 class SQLitePersistentCookieStore
     : public net::CookieMonster::PersistentCookieStore {
  public:
   SQLitePersistentCookieStore(const FilePath& path,
                               bool restore_old_session_cookies);
-  virtual ~SQLitePersistentCookieStore();
 
   virtual void Load(const LoadedCallback& loaded_callback) OVERRIDE;
 
   virtual void LoadCookiesForKey(const std::string& key,
       const LoadedCallback& callback) OVERRIDE;
 
   virtual void AddCookie(
       const net::CookieMonster::CanonicalCookie& cc) OVERRIDE;
 
   virtual void UpdateCookieAccessTime(
       const net::CookieMonster::CanonicalCookie& cc) OVERRIDE;
 
   virtual void DeleteCookie(
       const net::CookieMonster::CanonicalCookie& cc) OVERRIDE;
 
   virtual void SetClearLocalStateOnExit(bool clear_local_state) OVERRIDE;
 
   virtual void Flush(const base::Closure& callback) OVERRIDE;
 
  private:
   class Backend;
 
+  virtual ~SQLitePersistentCookieStore();

[eroman, 2012/04/13 18:47:25]

Is it intentional that these lack implementations?

[Ryan Sleevi, 2012/04/13 18:52:35]

The implementation is in the .cc file. All that changed was the placement.

[eroman, 2012/04/13 19:26:38]

oops, misread that!

+
   scoped_refptr<Backend> backend_;
 
   DISALLOW_COPY_AND_ASSIGN(SQLitePersistentCookieStore);
 };
 
 #endif  // CHROME_BROWSER_NET_SQLITE_PERSISTENT_COOKIE_STORE_H_