Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Unified Diff: chrome/browser/bookmarks/bookmark_html_writer.cc

Issue 10069052: RefCounted types should not have public destructors, chrome/browser/bookmarks/ edition (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Updates Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/bookmarks/bookmark_html_writer.cc
diff --git a/chrome/browser/bookmarks/bookmark_html_writer.cc b/chrome/browser/bookmarks/bookmark_html_writer.cc
index 2e9376e1cecd7e203b3a80ee91b3400623f28add..7dfe7efbb07088ae0bafef703884c3c3bb75fabc 100644
--- a/chrome/browser/bookmarks/bookmark_html_writer.cc
+++ b/chrome/browser/bookmarks/bookmark_html_writer.cc
@@ -151,6 +151,8 @@ class Writer : public base::RefCountedThreadSafe<Writer> {
}
private:
+ friend class base::RefCountedThreadSafe<Writer>;
+
// Types of text being written out. The type dictates how the text is
// escaped.
enum TextType {
@@ -162,6 +164,8 @@ class Writer : public base::RefCountedThreadSafe<Writer> {
CONTENT
};
+ ~Writer() {}
+
// Opens the file, returning true on success.
bool OpenFile() {
int flags = base::PLATFORM_FILE_CREATE_ALWAYS | base::PLATFORM_FILE_WRITE;
« no previous file with comments | « chrome/browser/bookmarks/bookmark_extension_api.h ('k') | chrome/browser/bookmarks/bookmark_manager_extension_api.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698