Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Unified Diff: chrome/browser/bookmarks/bookmark_manager_extension_api.h

Issue 10069052: RefCounted types should not have public destructors, chrome/browser/bookmarks/ edition (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Updates Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/bookmarks/bookmark_html_writer.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/bookmarks/bookmark_manager_extension_api.h
diff --git a/chrome/browser/bookmarks/bookmark_manager_extension_api.h b/chrome/browser/bookmarks/bookmark_manager_extension_api.h
index 8827806c82d317f72f7ba3deced16c478ac0b8ac..62d3acf8d6d613e147ed803ba448dd4a3fe58f15 100644
--- a/chrome/browser/bookmarks/bookmark_manager_extension_api.h
+++ b/chrome/browser/bookmarks/bookmark_manager_extension_api.h
@@ -55,95 +55,130 @@ class BookmarkManagerExtensionEventRouter
class ClipboardBookmarkManagerFunction : public BookmarksFunction {
protected:
+ virtual ~ClipboardBookmarkManagerFunction() {}
+
bool CopyOrCut(bool cut);
};
class CopyBookmarkManagerFunction : public ClipboardBookmarkManagerFunction {
public:
- virtual bool RunImpl() OVERRIDE;
-
- private:
DECLARE_EXTENSION_FUNCTION_NAME("experimental.bookmarkManager.copy");
+
+ protected:
+ virtual ~CopyBookmarkManagerFunction() {}
+
+ // ExtensionFunction:
+ virtual bool RunImpl() OVERRIDE;
};
class CutBookmarkManagerFunction : public ClipboardBookmarkManagerFunction {
public:
- virtual bool RunImpl() OVERRIDE;
-
- private:
DECLARE_EXTENSION_FUNCTION_NAME("experimental.bookmarkManager.cut");
+
+ protected:
+ virtual ~CutBookmarkManagerFunction() {}
+
+ // ExtensionFunction:
+ virtual bool RunImpl() OVERRIDE;
};
class PasteBookmarkManagerFunction : public BookmarksFunction {
public:
- virtual bool RunImpl() OVERRIDE;
-
- private:
DECLARE_EXTENSION_FUNCTION_NAME("experimental.bookmarkManager.paste");
+
+ protected:
+ virtual ~PasteBookmarkManagerFunction() {}
+
+ // ExtensionFunction:
+ virtual bool RunImpl() OVERRIDE;
};
class CanPasteBookmarkManagerFunction : public BookmarksFunction {
public:
- virtual bool RunImpl() OVERRIDE;
-
- private:
DECLARE_EXTENSION_FUNCTION_NAME("experimental.bookmarkManager.canPaste");
+
+ protected:
+ virtual ~CanPasteBookmarkManagerFunction() {}
+
+ // ExtensionFunction:
+ virtual bool RunImpl() OVERRIDE;
};
class SortChildrenBookmarkManagerFunction : public BookmarksFunction {
public:
- virtual bool RunImpl() OVERRIDE;
-
- private:
DECLARE_EXTENSION_FUNCTION_NAME("experimental.bookmarkManager.sortChildren");
+
+ protected:
+ virtual ~SortChildrenBookmarkManagerFunction() {}
+
+ // ExtensionFunction:
+ virtual bool RunImpl() OVERRIDE;
};
class BookmarkManagerGetStringsFunction : public AsyncExtensionFunction {
public:
- virtual bool RunImpl() OVERRIDE;
-
- private:
DECLARE_EXTENSION_FUNCTION_NAME("experimental.bookmarkManager.getStrings");
+
+ protected:
+ virtual ~BookmarkManagerGetStringsFunction() {}
+
+ // ExtensionFunction:
+ virtual bool RunImpl() OVERRIDE;
};
class StartDragBookmarkManagerFunction : public BookmarksFunction {
public:
- virtual bool RunImpl() OVERRIDE;
-
- private:
DECLARE_EXTENSION_FUNCTION_NAME("experimental.bookmarkManager.startDrag");
+
+ protected:
+ virtual ~StartDragBookmarkManagerFunction() {}
+
+ // ExtensionFunction:
+ virtual bool RunImpl() OVERRIDE;
};
class DropBookmarkManagerFunction : public BookmarksFunction {
public:
- virtual bool RunImpl() OVERRIDE;
-
- private:
DECLARE_EXTENSION_FUNCTION_NAME("experimental.bookmarkManager.drop");
+
+ protected:
+ virtual ~DropBookmarkManagerFunction() {}
+
+ // ExtensionFunction:
+ virtual bool RunImpl() OVERRIDE;
};
class GetSubtreeBookmarkManagerFunction : public BookmarksFunction {
public:
- virtual bool RunImpl() OVERRIDE;
-
- private:
DECLARE_EXTENSION_FUNCTION_NAME("experimental.bookmarkManager.getSubtree");
+
+ protected:
+ virtual ~GetSubtreeBookmarkManagerFunction() {}
+
+ // ExtensionFunction:
+ virtual bool RunImpl() OVERRIDE;
};
class CanEditBookmarkManagerFunction : public BookmarksFunction {
public:
- virtual bool RunImpl() OVERRIDE;
-
- private:
DECLARE_EXTENSION_FUNCTION_NAME("experimental.bookmarkManager.canEdit");
+
+ protected:
+ virtual ~CanEditBookmarkManagerFunction() {}
+
+ // ExtensionFunction:
+ virtual bool RunImpl() OVERRIDE;
};
class RecordLaunchBookmarkFunction : public BookmarksFunction {
public:
- virtual bool RunImpl() OVERRIDE;
-
- private:
DECLARE_EXTENSION_FUNCTION_NAME("experimental.bookmarkManager.recordLaunch")
+
+ protected:
+ virtual ~RecordLaunchBookmarkFunction() {}
+
+ // ExtensionFunction:
+ virtual bool RunImpl() OVERRIDE;
};
#endif // CHROME_BROWSER_BOOKMARKS_BOOKMARK_MANAGER_EXTENSION_API_H_
« no previous file with comments | « chrome/browser/bookmarks/bookmark_html_writer.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698