RefCounted types should not have public destructors, chrome/browser/bookmarks/ edition

RefCounted types should not have public destructors, chrome/browser/bookmarks/ edition

BUG=123295
TEST=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=133829

[Ryan Sleevi, 2012-04-13 08:50:40]

sky: PTAL

[sky, 2012-04-13 15:48:16]

LGTM
Make sure you do a try with the clang bots though. You might need to move the
implementation to the .cc.

[Ryan Sleevi, 2012-04-24 22:42:37]

sky: Since this is meaningfully updated, please take another look.

The change was motivated by the fact that BookmarksFunction::RunImpl() was
shadowing ExtensionFunction::RunImpl() [which is fine, they're both virtual],
but at a different accessibility - ExtensionFunction is protected, while
BookmarksFunction was marked public.

Also, following the style cops, this moves DECLARE_EXTENSION_FUNCTION_NAME()
into the public section, since that's effectively what it's doing (Its #define'd
to include a 'public:' at the beginning), so that the order of decls goes public
-> protected -> private

[sky, 2012-04-24 23:14:41]

LGTM

[commit-bot: I haz the power, 2012-04-24 23:17:22]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rsleevi@chromium.org/10069052/5001

[commit-bot: I haz the power, 2012-04-25 01:00:33]

Change committed as 133829