Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1148)

Unified Diff: chrome/browser/download/save_package_file_picker.h

Issue 10069014: Save Page As MHTML (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: nonconst nonref params Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/download/save_package_file_picker.h
diff --git a/chrome/browser/download/save_package_file_picker.h b/chrome/browser/download/save_package_file_picker.h
index c3b622c220e1c3b86cf6a28bba46c4a6ff1634c8..e74fa5427bb8db8ffc2a047fe803cffc44adef89 100644
--- a/chrome/browser/download/save_package_file_picker.h
+++ b/chrome/browser/download/save_package_file_picker.h
@@ -6,7 +6,6 @@
#define CHROME_BROWSER_DOWNLOAD_SAVE_PACKAGE_FILE_PICKER_H_
#pragma once
-#include "base/callback.h"
#include "base/memory/ref_counted.h"
#include "chrome/browser/ui/select_file_dialog.h"
#include "content/public/browser/download_manager_delegate.h"
@@ -17,8 +16,8 @@ class DownloadPrefs;
class SavePackageFilePicker : public SelectFileDialog::Listener {
public:
SavePackageFilePicker(content::WebContents* web_contents,
- const FilePath& suggested_path,
- const FilePath::StringType& default_extension,
+ FilePath suggested_path,
achuithb 2012/04/24 22:06:09 I don't think you should do this. If you need to m
achuithb 2012/04/24 22:28:14 Just saw Randy's note. Personally not a fan of fun
+ FilePath::StringType default_extension,
bool can_save_as_complete,
DownloadPrefs* download_prefs,
content::SaveFilePathPickedCallback callback);
@@ -32,12 +31,17 @@ class SavePackageFilePicker : public SelectFileDialog::Listener {
// SelectFileDialog::Listener implementation.
virtual void FileSelected(const FilePath& path,
int index,
- void* params) OVERRIDE;
- virtual void FileSelectionCanceled(void* params) OVERRIDE;
+ void* unused_params) OVERRIDE;
+ virtual void FileSelectionCanceled(void* unused_params) OVERRIDE;
+
+ bool ShouldSaveAsMHTML() const;
// Used to look up the renderer process for this request to get the context.
int render_process_id_;
+ // Whether the web page can be saved as a complete HTML file.
+ bool can_save_as_complete_;
+
content::SaveFilePathPickedCallback callback_;
// For managing select file dialogs.

Powered by Google App Engine
This is Rietveld 408576698