Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(613)

Unified Diff: chrome/browser/download/chrome_download_manager_delegate.cc

Issue 10069014: Save Page As MHTML (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: nonconst nonref params Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/download/chrome_download_manager_delegate.cc
diff --git a/chrome/browser/download/chrome_download_manager_delegate.cc b/chrome/browser/download/chrome_download_manager_delegate.cc
index b0323ddd25a3921a6fffe22d6d6d09306f2fbe66..489744b14f7a5d85cecf3b30b4f3bf377093dfdc 100644
--- a/chrome/browser/download/chrome_download_manager_delegate.cc
+++ b/chrome/browser/download/chrome_download_manager_delegate.cc
@@ -154,11 +154,11 @@ void ChromeDownloadManagerDelegate::ChooseDownloadPath(
int32 download_id) {
// Deletes itself.
#if defined(OS_CHROMEOS)
- new DownloadFilePickerChromeOS(
+ new DownloadFilePickerChromeOS
#else
- new DownloadFilePicker(
+ new DownloadFilePicker
#endif
- download_manager_, web_contents, suggested_path, download_id);
+ (download_manager_, web_contents, suggested_path, download_id);
}
FilePath ChromeDownloadManagerDelegate::GetIntermediatePath(
@@ -375,10 +375,7 @@ void ChromeDownloadManagerDelegate::ChooseSavePath(
content::SaveFilePathPickedCallback callback) {
// Deletes itself.
#if defined(OS_CHROMEOS)
- // Note that we're ignoring the callback here.
- // SavePackageFilePickerChromeOS completes the save operation itself.
- // TODO(achuith): Fix this.
- new SavePackageFilePickerChromeOS(web_contents, suggested_path);
+ new SavePackageFilePickerChromeOS(web_contents, suggested_path, callback);
#else
new SavePackageFilePicker(web_contents, suggested_path, default_extension,
can_save_as_complete, download_prefs_.get(), callback);

Powered by Google App Engine
This is Rietveld 408576698