content/browser/resolve_proxy_msg_helper.h - Issue 10068037: RefCounted types should not have public destructors, content/browser part 1

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/resolve_proxy_msg_helper.h

Issue 10068037: RefCounted types should not have public destructors, content/browser part 1 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Implementation ordering Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/renderer_host/media/audio_renderer_host_unittest.cc ('K') | « content/browser/renderer_host/text_input_client_message_filter.mm ('k') | content/browser/resolve_proxy_msg_helper.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/resolve_proxy_msg_helper.h

diff --git a/content/browser/resolve_proxy_msg_helper.h b/content/browser/resolve_proxy_msg_helper.h

index 920ff74199f74457e4de22fea7702d6654a4f43f..a575ed8acf7b4d32ad6798d7ab7b55505f01a5f3 100644

--- a/content/browser/resolve_proxy_msg_helper.h

+++ b/content/browser/resolve_proxy_msg_helper.h

@@ -37,16 +37,17 @@ class CONTENT_EXPORT ResolveProxyMsgHelper

// Constructor used by unittests.

explicit ResolveProxyMsgHelper(net::ProxyService* proxy_service);

- // Destruction cancels the current outstanding request, and clears the

- // pending queue.

- virtual ~ResolveProxyMsgHelper();

// content::BrowserMessageFilter implementation

virtual bool OnMessageReceived(const IPC::Message& message,

bool* message_was_ok) OVERRIDE;

void OnResolveProxy(const GURL& url, IPC::Message* reply_msg);

+ protected:

+ // Destruction cancels the current outstanding request, and clears the

+ // pending queue.

+ virtual ~ResolveProxyMsgHelper();

private:

// Callback for the ProxyService (bound to |callback_|).

void OnResolveProxyCompleted(int result);