content/browser/renderer_host/text_input_client_message_filter.mm - Issue 10068037: RefCounted types should not have public destructors, content/browser part 1

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/text_input_client_message_filter.mm

Issue 10068037: RefCounted types should not have public destructors, content/browser part 1 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Implementation ordering Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/renderer_host/media/audio_renderer_host_unittest.cc ('K') | « content/browser/renderer_host/text_input_client_message_filter.h ('k') | content/browser/resolve_proxy_msg_helper.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/text_input_client_message_filter.mm

diff --git a/content/browser/renderer_host/text_input_client_message_filter.mm b/content/browser/renderer_host/text_input_client_message_filter.mm

index efc2ac9124e54573ae7514fe6d5c06e58db5d816..e577f274014e50e40258b4610a9567d38b8b762a 100644

--- a/content/browser/renderer_host/text_input_client_message_filter.mm

+++ b/content/browser/renderer_host/text_input_client_message_filter.mm

@@ -22,9 +22,6 @@ TextInputClientMessageFilter::TextInputClientMessageFilter(int child_id)

child_process_id_(child_id) {

}

-TextInputClientMessageFilter::~TextInputClientMessageFilter() {

bool TextInputClientMessageFilter::OnMessageReceived(

const IPC::Message& message,

bool* message_was_ok) {

@@ -42,6 +39,8 @@ bool TextInputClientMessageFilter::OnMessageReceived(

return handled;

}

+TextInputClientMessageFilter::~TextInputClientMessageFilter() {}

void TextInputClientMessageFilter::OnGotCharacterIndexForPoint(size_t index) {

TextInputClientMac* service = TextInputClientMac::GetInstance();

// |index| could be WTF::notFound (-1) and its value is different from