chrome/browser/safe_browsing/safe_browsing_blocking_page_unittest.cc - Issue 10068036: RefCounted types should not have public destructors, chrome/browser/ part 5

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/safe_browsing_blocking_page_unittest.cc

Issue 10068036: RefCounted types should not have public destructors, chrome/browser/ part 5 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Win fix Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc ('k') | chrome/browser/safe_browsing/safe_browsing_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/safe_browsing/safe_browsing_blocking_page_unittest.cc

diff --git a/chrome/browser/safe_browsing/safe_browsing_blocking_page_unittest.cc b/chrome/browser/safe_browsing/safe_browsing_blocking_page_unittest.cc

index 3d5588961a64963378b491d25a682de40b3f8cfa..6394fe62811f7fee6d6123d8978435ddb9177f3b 100644

--- a/chrome/browser/safe_browsing/safe_browsing_blocking_page_unittest.cc

+++ b/chrome/browser/safe_browsing/safe_browsing_blocking_page_unittest.cc

@@ -47,8 +47,6 @@ class TestSafeBrowsingBlockingPage : public SafeBrowsingBlockingPage {

class TestSafeBrowsingService: public SafeBrowsingService {

public:

- virtual ~TestSafeBrowsingService() {}

virtual void SendSerializedMalwareDetails(const std::string& serialized) {

details_.push_back(serialized);

}

@@ -57,6 +55,9 @@ class TestSafeBrowsingService: public SafeBrowsingService {

return &details_;

}

+ private:

+ virtual ~TestSafeBrowsingService() {}

std::list<std::string> details_;

};