Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Unified Diff: chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc

Issue 10068036: RefCounted types should not have public destructors, chrome/browser/ part 5 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Win fix Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc
diff --git a/chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc b/chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc
index 6ed95f052392dda9625e2f5a056ffdc453b1f821..b6d96ae038a540ebb0ec51bb700350794a712b21 100644
--- a/chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc
+++ b/chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc
@@ -37,8 +37,6 @@ class FakeSafeBrowsingService : public SafeBrowsingService {
public:
FakeSafeBrowsingService() {}
- virtual ~FakeSafeBrowsingService() {}
-
// Called on the IO thread to check if the given url is safe or not. If we
// can synchronously determine that the url is safe, CheckUrl returns true.
// Otherwise it returns false, and "client" is called asynchronously with the
@@ -89,6 +87,8 @@ class FakeSafeBrowsingService : public SafeBrowsingService {
std::vector<std::string> reports_;
private:
+ virtual ~FakeSafeBrowsingService() {}
+
base::hash_map<std::string, UrlCheckResult> badurls;
};
@@ -111,8 +111,6 @@ class FakeMalwareDetails : public MalwareDetails {
const SafeBrowsingService::UnsafeResource& unsafe_resource)
: MalwareDetails(sb_service, web_contents, unsafe_resource) { }
- virtual ~FakeMalwareDetails() {}
-
virtual void AddDOMDetails(
const std::vector<SafeBrowsingHostMsg_MalwareDOMDetails_Node>& params) {
EXPECT_TRUE(BrowserThread::CurrentlyOn(BrowserThread::IO));
@@ -152,6 +150,8 @@ class FakeMalwareDetails : public MalwareDetails {
}
private:
+ virtual ~FakeMalwareDetails() {}
+
// Some logic to figure out if we should wait for the dom details or not.
// These variables should only be accessed in the UI thread.
bool got_dom_;

Powered by Google App Engine
This is Rietveld 408576698