Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1019)

Unified Diff: chrome/browser/prefs/value_map_pref_store.h

Issue 10068036: RefCounted types should not have public destructors, chrome/browser/ part 5 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Win fix Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/prefs/testing_pref_store.cc ('k') | chrome/browser/prefs/value_map_pref_store.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/prefs/value_map_pref_store.h
diff --git a/chrome/browser/prefs/value_map_pref_store.h b/chrome/browser/prefs/value_map_pref_store.h
index b440ba1c84d8e6d401d8934d49fdb978080781c4..011a370f473468dfcd84d08d849ffc1bbf8653c5 100644
--- a/chrome/browser/prefs/value_map_pref_store.h
+++ b/chrome/browser/prefs/value_map_pref_store.h
@@ -22,7 +22,6 @@ class ValueMapPrefStore : public PrefStore {
typedef std::map<std::string, base::Value*>::const_iterator const_iterator;
ValueMapPrefStore();
- virtual ~ValueMapPrefStore();
// PrefStore overrides:
virtual ReadResult GetValue(const std::string& key,
@@ -37,6 +36,8 @@ class ValueMapPrefStore : public PrefStore {
const_iterator end() const;
protected:
+ virtual ~ValueMapPrefStore();
+
// Store a |value| for |key| in the store. Also generates an notification if
// the value changed. Assumes ownership of |value|, which must be non-NULL.
void SetValue(const std::string& key, base::Value* value);
« no previous file with comments | « chrome/browser/prefs/testing_pref_store.cc ('k') | chrome/browser/prefs/value_map_pref_store.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698