Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1004)

Unified Diff: chrome/browser/prefs/value_map_pref_store.cc

Issue 10068036: RefCounted types should not have public destructors, chrome/browser/ part 5 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Win fix Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/prefs/value_map_pref_store.cc
diff --git a/chrome/browser/prefs/value_map_pref_store.cc b/chrome/browser/prefs/value_map_pref_store.cc
index 6bb1decd0c29bc38d6fb51d3a80bbb199a84bab0..98f9cdd3c7c25d3851119bf71fdf8fd3f2593945 100644
--- a/chrome/browser/prefs/value_map_pref_store.cc
+++ b/chrome/browser/prefs/value_map_pref_store.cc
@@ -11,8 +11,6 @@
ValueMapPrefStore::ValueMapPrefStore() {}
-ValueMapPrefStore::~ValueMapPrefStore() {}
-
PrefStore::ReadResult ValueMapPrefStore::GetValue(const std::string& key,
const Value** value) const {
return prefs_.GetValue(key, value) ? READ_OK : READ_NO_VALUE;
@@ -30,20 +28,6 @@ size_t ValueMapPrefStore::NumberOfObservers() const {
return observers_.size();
}
-void ValueMapPrefStore::SetValue(const std::string& key, Value* value) {
- if (prefs_.SetValue(key, value))
- FOR_EACH_OBSERVER(Observer, observers_, OnPrefValueChanged(key));
-}
-
-void ValueMapPrefStore::RemoveValue(const std::string& key) {
- if (prefs_.RemoveValue(key))
- FOR_EACH_OBSERVER(Observer, observers_, OnPrefValueChanged(key));
-}
-
-void ValueMapPrefStore::NotifyInitializationCompleted() {
- FOR_EACH_OBSERVER(Observer, observers_, OnInitializationCompleted(true));
-}
-
ValueMapPrefStore::iterator ValueMapPrefStore::begin() {
return prefs_.begin();
}
@@ -59,3 +43,19 @@ ValueMapPrefStore::const_iterator ValueMapPrefStore::begin() const {
ValueMapPrefStore::const_iterator ValueMapPrefStore::end() const {
return prefs_.end();
}
+
+ValueMapPrefStore::~ValueMapPrefStore() {}
+
+void ValueMapPrefStore::SetValue(const std::string& key, Value* value) {
+ if (prefs_.SetValue(key, value))
+ FOR_EACH_OBSERVER(Observer, observers_, OnPrefValueChanged(key));
+}
+
+void ValueMapPrefStore::RemoveValue(const std::string& key) {
+ if (prefs_.RemoveValue(key))
+ FOR_EACH_OBSERVER(Observer, observers_, OnPrefValueChanged(key));
+}
+
+void ValueMapPrefStore::NotifyInitializationCompleted() {
+ FOR_EACH_OBSERVER(Observer, observers_, OnInitializationCompleted(true));
+}
« no previous file with comments | « chrome/browser/prefs/value_map_pref_store.h ('k') | chrome/browser/printing/cloud_print/cloud_print_proxy_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698